[prev in list] [next in list] [prev in thread] [next in thread]
List: lucene-dev
Subject: Re: issue with modules while building PyLucene
From: Dawid Weiss <dawid.weiss () gmail ! com>
Date: 2022-01-04 18:56:50
Message-ID: CAM21Rt-aeECn6nOWNX3s5gHeGHF=OErgKE++yAKSXLrxOj5W_w () mail ! gmail ! com
[Download RAW message or body]
For the record - that module-info.class isn't really needed since Lucene is
designed to work fine in classpath mode anyway (and in classpath mode the
module info is ignored too).
On Tue, Jan 4, 2022 at 7:52 PM Andi Vajda <osaf@ovaltofu.org> wrote:
>
> On Tue, 4 Jan 2022, Dawid Weiss wrote:
>
> > You have to exclude that module-info.class from processing somehow, Andi.
> > It isn't a proper class indeed. Can jcc accept an exclusion pattern
> somehow?
>
> Oh yes, that's not a problem, just add it via --exclude, let me try that
> and
> report back.
>
> Andi..
>
> >
> > Dawid
> >
> > On Tue, Jan 4, 2022 at 7:36 PM Andi Vajda <osaf@ovaltofu.org> wrote:
> >
> >>
> >> Hi,
> >>
> >> I was able to build PyLucene with Lucene 9.0 and have it pass all its
> >> tests.
> >> Now, I moved to branch_9x (to get access to the new collectRuntimeJars
> >> Gradle task) and I'm hitting an issue that seems to be related to the
> new
> >> work around java modules:
> >>
> >> Exception in thread "main" java.lang.NoClassDefFoundError:
> module-info
> >> is
> >> not a class because access_flag ACC_MODULE is set
> >>
> >> I now nothing about java modules so maybe this is trivial or
> non-sensical
> >> but all JCC is doing with the Lucene jars in order to build PyLucene is
> to
> >> load them, walk their class trees and, using reflection, generate
> wrappers
> >> for the publicly accessible methods and some extra ones as well, as
> listed
> >> in the JCC command line (at line 215 in PyLucene's Makefile here:
> >> https://svn.apache.org/repos/asf/lucene/pylucene/trunk/Makefile
> >>
> >> Is there an easy way to disable the module feature ? (does this question
> >> even make sense ? is there a proper way to do what JCC is doing with
> >> modules
> >> enabled ?)
> >>
> >> Thanks !
> >>
> >> Andi..
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >> For additional commands, e-mail: dev-help@lucene.apache.org
> >>
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
[Attachment #3 (text/html)]
<div dir="ltr"><br><div>For the record - that module-info.class isn't really \
needed since Lucene is designed to work fine in classpath mode anyway (and in \
classpath mode the module info is ignored too).</div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jan 4, 2022 at 7:52 PM \
Andi Vajda <<a href="mailto:osaf@ovaltofu.org">osaf@ovaltofu.org</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> On Tue, 4 Jan \
2022, Dawid Weiss wrote:<br> <br>
> You have to exclude that module-info.class from processing somehow, Andi.<br>
> It isn't a proper class indeed. Can jcc accept an exclusion pattern \
somehow?<br> <br>
Oh yes, that's not a problem, just add it via --exclude, let me try that and <br>
report back.<br>
<br>
Andi..<br>
<br>
><br>
> Dawid<br>
><br>
> On Tue, Jan 4, 2022 at 7:36 PM Andi Vajda <<a href="mailto:osaf@ovaltofu.org" \
target="_blank">osaf@ovaltofu.org</a>> wrote:<br> ><br>
>><br>
>> Hi,<br>
>><br>
>> I was able to build PyLucene with Lucene 9.0 and have it pass all its<br>
>> tests.<br>
>> Now, I moved to branch_9x (to get access to the new collectRuntimeJars<br>
>> Gradle task) and I'm hitting an issue that seems to be related to the \
new<br> >> work around java modules:<br>
>><br>
>> Exception in thread "main" java.lang.NoClassDefFoundError: \
module-info<br> >> is<br>
>> not a class because access_flag ACC_MODULE is set<br>
>><br>
>> I now nothing about java modules so maybe this is trivial or \
non-sensical<br> >> but all JCC is doing with the Lucene jars in order to build \
PyLucene is to<br> >> load them, walk their class trees and, using reflection, \
generate wrappers<br> >> for the publicly accessible methods and some extra \
ones as well, as listed<br> >> in the JCC command line (at line 215 in \
PyLucene's Makefile here:<br> >> <a \
href="https://svn.apache.org/repos/asf/lucene/pylucene/trunk/Makefile" \
rel="noreferrer" target="_blank">https://svn.apache.org/repos/asf/lucene/pylucene/trunk/Makefile</a><br>
>><br>
>> Is there an easy way to disable the module feature ? (does this question<br>
>> even make sense ? is there a proper way to do what JCC is doing with<br>
>> modules<br>
>> enabled ?)<br>
>><br>
>> Thanks !<br>
>><br>
>> Andi..<br>
>><br>
>> ---------------------------------------------------------------------<br>
>> To unsubscribe, e-mail: <a href="mailto:dev-unsubscribe@lucene.apache.org" \
target="_blank">dev-unsubscribe@lucene.apache.org</a><br> >> For additional \
commands, e-mail: <a href="mailto:dev-help@lucene.apache.org" \
target="_blank">dev-help@lucene.apache.org</a><br> >><br>
>><br>
><br>
<br>
---------------------------------------------------------------------<br>
To unsubscribe, e-mail: <a href="mailto:dev-unsubscribe@lucene.apache.org" \
target="_blank">dev-unsubscribe@lucene.apache.org</a><br> For additional commands, \
e-mail: <a href="mailto:dev-help@lucene.apache.org" \
target="_blank">dev-help@lucene.apache.org</a><br> <br>
</blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic