[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lucene-dev
Subject:    [jira] [Updated] (LUCENE-5850) Constants#LUCENE_MAIN_VERSION can have broken values
From:       "Uwe Schindler (JIRA)" <jira () apache ! org>
Date:       2014-07-31 20:32:39
Message-ID: JIRA.12730174.1406545957132.89559.1406838759736 () arcas
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

Uwe Schindler updated LUCENE-5850:
----------------------------------

    Attachment: LUCENE-5850.patch

Patch with Shai's suggestion.

> Constants#LUCENE_MAIN_VERSION can have broken values 
> -----------------------------------------------------
> 
> Key: LUCENE-5850
> URL: https://issues.apache.org/jira/browse/LUCENE-5850
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.3.1, 4.5.1
> Reporter: Simon Willnauer
> Fix For: 5.0, 4.10
> 
> Attachments: LUCENE-5850.patch, LUCENE-5850.patch, LUCENE-5850.patch, \
> LUCENE-5850.patch, LUCENE-5850.patch, LUCENE-5850.patch, LUCENE-5850_bomb.patch, \
> LUCENE-5850_smoketester.patch 
> 
> Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should not \
> contain minor versions. Well this is at least what I thought and to my knowledge \
> what the comments say too. Yet in for instance 4.3.1 and 4.5.1 we broke this such \
> that the version from SegmentsInfo can not be parsed with Version#parseLeniently. \
> IMO we should really add an assertion that this constant doesn't throw an error and \
> / or make the smoketester catch this. to me this is actually a index BWC break. \
> Note that 4.8.1 doesn't have this problem...



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]