[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lucene-dev
Subject:    [jira] [Commented] (LUCENE-3055) LUCENE-2372, LUCENE-2389 made it
From:       "Earwin Burrfoot (JIRA)" <jira () apache ! org>
Date:       2011-04-30 19:14:03
Message-ID: 1968900027.13715.1304190843137.JavaMail.tomcat () hel ! zones ! apache ! org
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/LUCENE-3055?page=com.atlassian.jira.plugin \
.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027361#comment-13027361 ] 

Earwin Burrfoot commented on LUCENE-3055:
-----------------------------------------

Could anyone remind me, why the hell do we still have Analyzer.tokenStream AND \
reusableTokenStream rampaging around and confusing minds? We always recommend to use \
the latter, Robert just fixed some of the core classes to use the latter.

Also, if reusableTokenStream is the only method left standing, isn't it wise to hide \
actual reuse somewhere in Lucene internals and turn Analyzer into plain and dumb \
factory interface?

> LUCENE-2372, LUCENE-2389 made it impossible to subclass core analyzers
> ----------------------------------------------------------------------
> 
> Key: LUCENE-3055
> URL: https://issues.apache.org/jira/browse/LUCENE-3055
> Project: Lucene - Java
> Issue Type: Bug
> Components: Analysis
> Affects Versions: 3.1
> Reporter: Ian Soboroff
> 
> LUCENE-2372 and LUCENE-2389 marked all analyzers as final.  This makes \
> ReusableAnalyzerBase useless, and makes it impossible to subclass e.g. \
> StandardAnalyzer to make a small modification e.g. to tokenStream().  These issues \
> don't indicate a new method of doing this.  The issues don't give a reason except \
> for design considerations, which seems a poor reason to make a \
> backward-incompatible change

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]