[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lucene-dev
Subject:    [jira] [Updated] (LUCENE-3054) add assert to sorts catch broken
From:       "Robert Muir (JIRA)" <jira () apache ! org>
Date:       2011-04-29 18:34:03
Message-ID: 417847907.12301.1304102043659.JavaMail.tomcat () hel ! zones ! apache ! org
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/LUCENE-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

Robert Muir updated LUCENE-3054:
--------------------------------

    Attachment: LUCENE-3054.patch

i expanded the patch to all the sorts, just to find all the wierd sorting/comparators \
going on.

it also finds some false positives, ones that are documented as inconsistent with \
equals, ones in tests, etc.

but we can at least look into the ones it finds.

> add assert to sorts catch broken comparators in tests
> -----------------------------------------------------
> 
> Key: LUCENE-3054
> URL: https://issues.apache.org/jira/browse/LUCENE-3054
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 3.1
> Reporter: Robert Muir
> Attachments: LUCENE-3054.patch, LUCENE-3054.patch
> 
> 
> Looking at Otis's sort problem on the mailing list, he said:
> {noformat}
> * looked for other places where this call is made - found it in
> MultiPhraseQuery$MultiPhraseWeight and changed that call from
> ArrayUtil.quickSort to ArrayUtil.mergeSort
> * now we no longer see SorterTemplate.quickSort in deep recursion when we do a
> thread dump
> {noformat}
> I thought this was interesting because PostingsAndFreq's comparator
> looks like it needs a tiebreaker.
> I think in our sorts we should add some asserts to try to catch some of these \
> broken comparators.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]