[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lucene-dev
Subject:    [jira] Commented: (LUCENE-2084) remove Byte/CharBuffer wrapping for
From:       "Steven Rowe (JIRA)" <jira () apache ! org>
Date:       2009-12-30 15:48:29
Message-ID: 1391455516.1262188109432.JavaMail.jira () brutus ! apache ! org
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin \
.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795337#action_12795337 ] 

Steven Rowe commented on LUCENE-2084:
-------------------------------------

{quote}
bq. 3. Unlike getEncodedLength(byte[],int,int), getDecodedLength(char[],int,int) \
doesn't protect against overflow in the int multiplication by casting to long.

#3 concerns me somewhat, this is an existing problem in trunk (i guess only for \
enormous terms, though). Should we consider backporting a fix? {quote}

The current form of this calculation will correctly handle original binary content of \
lengths up to 136MB.  IMHO the likelihood of encoding terms this enormous with \
IndexableBinaryStringTools is so miniscule that it's not worth the effort to \
backport.

> remove Byte/CharBuffer wrapping for collation key generation
> ------------------------------------------------------------
> 
> Key: LUCENE-2084
> URL: https://issues.apache.org/jira/browse/LUCENE-2084
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
> 
> Attachments: collation.benchmark.tar.bz2, LUCENE-2084.patch, LUCENE-2084.patch, \
> LUCENE-2084.patch, LUCENE-2084.patch, LUCENE-2084.patch, LUCENE-2084.patch, \
> TopTFWikipediaWords.tar.bz2 
> 
> We can remove the overhead of ByteBuffer and CharBuffer wrapping in \
> CollationKeyFilter and ICUCollationKeyFilter. this patch moves the logic in \
> IndexableBinaryStringTools into char[],int,int and byte[],int,int based methods, \
> with the previous Byte/CharBuffer methods delegating to these. Previously, the \
> Byte/CharBuffer methods required a backing array anyway.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]