[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lucene-dev
Subject:    [jira] Updated: (LUCENE-635) [PATCH] Decouple locking
From:       "Michael McCandless (JIRA)" <jira () apache ! org>
Date:       2006-08-27 11:46:28
Message-ID: 8752689.1156679188144.JavaMail.jira () brutus
[Download RAW message or body]

     [ http://issues.apache.org/jira/browse/LUCENE-635?page=all ]

Michael McCandless updated LUCENE-635:
--------------------------------------

    Attachment: LUCENE-635-Aug27.patch

OK, I agree.  I've updated the CHANGES.txt to state this small change.

And I've fixed SimpleFSLockFactory to move directory existence checking & creation \
back into the obtain() method.

New patch attached!

> [PATCH] Decouple locking implementation from Directory implementation
> ---------------------------------------------------------------------
> 
> Key: LUCENE-635
> URL: http://issues.apache.org/jira/browse/LUCENE-635
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.0.0
> Reporter: Michael McCandless
> Priority: Minor
> Attachments: LUCENE-635-Aug27.patch, LUCENE-635-Aug3.patch, patch-Jul26.tar
> 
> 
> This is a spinoff of http://issues.apache.org/jira/browse/LUCENE-305.
> I've opened this new issue to capture that it's wider scope than
> LUCENE-305.
> This is a patch originally created by Jeff Patterson (see above link)
> and then modified as described here:
> http://issues.apache.org/jira/browse/LUCENE-305#action_12418493
> with some small additional changes:
> * For each FSDirectory.getDirectory(), I made a corresponding
> version that also accepts a LockFactory instance.  So, you can
> construct an FSDirectory with your own LockFactory.
> * Cascaded defaulting for FSDirectory's LockFactory implementation:
> if you pass in a LockFactory instance, it's used; else if
> setDisableLocks was called, we use NoLockFactory; else, if the
> system property "org.apache.lucene.store.FSDirectoryLockFactoryClass"
> is defined, we use that; finally, we'll use the original locking
> implementation (SimpleFSLockFactory).
> The gist is that all locking code has been moved out of *Directory and
> into subclasses of a new abstract LockFactory class.  You can now set
> the LockFactory of a Directory to change how it does locking.  For
> example, you can create an FSDirectory but set its locking to
> SingleInstanceLockFactory (if you know all writing/reading will take
> place a single JVM).
> The changes pass all unit tests (on Ubuntu Linux Sun Java 1.5 and
> Windows XP Sun Java 1.4), and I added another TestCase to test the
> LockFactory code.
> Note that LockFactory defaults are not changed: FSDirectory defaults
> to SimpleFSLockFactory and RAMDirectory defaults to
> SingleInstanceLockFactory.
> Next step (separate issue) is to create a LockFactory that uses the OS
> native locks (through java.nio).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: \
                http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]