[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lua-l
Subject:    Re: redundant gkey and key2tval in ltable.h (5.2.0-work3)
From:       Roberto Ierusalimschy <roberto () inf ! puc-rio ! br>
Date:       2010-06-24 16:56:34
Message-ID: 20100624165634.GF1279 () inf ! puc-rio ! br
[Download RAW message or body]

> Lua 5.1.4 ltable.h contains this:
> 
>   #define gkey(n)       (&(n)->i_key.nk)
>   #define key2tval(n)  (&(n)->i_key.tvk)
> 
> Lua 5.2.0-work3 makes them identical:
> 
>   #define gkey(n)      (&(n)->i_key.tvk)
>   #define key2tval(n) (&(n)->i_key.tvk)
> 
> nk (anonymous struct) and tvk (TValue) differ only in type because
> they are members of the same union.  Any reason not to eliminate
> key2tval(n) ?

No, I guess.

-- Roberto
[prev in list] [next in list] [prev in thread] [next in thread]