[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ltp-list
Subject:    Re: [LTP] [PATCH] netns: remove accumulated errmesg assignment
From:       chrubis () suse ! cz
Date:       2013-11-27 12:50:43
Message-ID: 20131127125043.GB7549 () rei ! suse ! cz
[Download RAW message or body]

Hi!
> > I wonder why there is errmesg variable at all and not just echo, it
> > doesn't seems to be used anywhere else.
> 
> I wonder too, but I thought there might be some reason, so I only fix
> the error and leave the imperfect behind.

I'm perfectly happy with applying this patch, but I would be even
happier with fixing it up correctly.

> > Moreover the way the testcases are executed is not well designed, the
> > runtest file 'containers' executes script container_test.sh which
> > executes several scripts and the scripts finally executes the tescases.
> > This is really nightmare if you are trying to find what fails and why...
> >
> > It would be much better to execute the testcases directly one by one
> > from the runtest file, and in most of the cases that would just need to
> > move code the checks if there is support for particual container to the
> > testcases.
> 
> Can't agree more, but it takes time to change the whole structure in
> testcases/kernel/containers/netns/ ...

We can do that easily in a few steps. First we need to add checks if the
containers are enabled to the actual testcases (that will not break
anything), then we can add new runtest file for them and once everything
is working, we can finally remove the original scripts.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
[prev in list] [next in list] [prev in thread] [next in thread]