[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ltp-list
Subject:    [LTP] [LNG][PATCH V2 1/2] ltp-networking/tcp_cmds/finger: fix finger test
From:       Vincent Hsu <vincent.hsu () linaro ! org>
Date:       2013-11-27 6:37:51
Message-ID: 1385534272-32414-2-git-send-email-vincent.hsu () linaro ! org
[Download RAW message or body]

Ubuntu use modified finger command. finger an unknown host test will
return nonzero on Ubuntu 12.04 even if successful execution.

for example:
on Ubuntu
    finger @xxx 2>&1 1>/dev/null ; echo $?
will return
    finger: unknown host: xxx
    getaddrinfo: No address associated with hostname
    1
on CentOS
    finger @xxx 2>&1 1>/dev/null ; echo $?
will return
    finger: xxx: nodename nor servname provided, or not known
    0

Signed-off-by: Vincent Hsu <vincent.hsu@linaro.org>
---
 testcases/network/tcp_cmds/finger/finger01 |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/testcases/network/tcp_cmds/finger/finger01 b/testcases/network/tcp_cmds/finger/finger01
index 6a72c8f..81da3e0 100755
--- a/testcases/network/tcp_cmds/finger/finger01
+++ b/testcases/network/tcp_cmds/finger/finger01
@@ -116,8 +116,10 @@ do_test2()

     tst_resm TINFO "finger -bad user "
     finger $BADUSER 2>&1 1>/dev/null || end_testcase "finger $BADUSER"
-    finger @$BADHOST 2>&1 1>/dev/null || end_testcase "finger @$BADHOST"
-    if ! finger $BADUSER@$BADHOST 2>&1 1>/dev/null; then
+    finger @$BADHOST 2>&1 1>/dev/null | grep "finger: unknown host" \
+        || end_testcase "finger @$BADHOST"
+    if ! finger $BADUSER@$BADHOST 2>&1 1>/dev/null \
+        | grep "finger: unknown host"; then
         end_testcase "finger $BADUSER@$BADHOST"
     fi
 }
@@ -158,7 +160,8 @@ do_test3()
         end_testcase "finger -m $RUSER@$RHOST"
     fi

-    tst_resm TINFO "finger -p : suppresses printing of .plan files on long and brief long formats"
+    tst_resm TINFO "finger -p : suppresses printing of .plan files on long and \
+        brief long formats"
     finger -p  2>&1 1>/dev/null || end_testcase "finger -p"
     finger -p $LUSER  2>&1 1>/dev/null || end_testcase "finger -p $LUSER"
     finger -p @$LHOST  2>&1 1>/dev/null || end_testcase "finger -p @$LHOST"
--
1.7.9.5


------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
[prev in list] [next in list] [prev in thread] [next in thread]