[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ltp-list
Subject:    Re: [LTP] [PATCH] shmget/shmget01.c: cleanup and attach SHM_NORESERVE to shmflg
From:       DAN LI <li.dan () cn ! fujitsu ! com>
Date:       2013-05-31 7:25:22
Message-ID: 51A85062.7080406 () cn ! fujitsu ! com
[Download RAW message or body]

On 05/29/2013 07:27 PM, Caspar Zhang wrote:
> On 05/29/2013 06:25 PM, DAN LI wrote:
>> On 05/29/2013 05:18 PM, Jan Stancek wrote:
>>>
>>> ----- Original Message -----
>>>> From: "DAN LI" <li.dan@cn.fujitsu.com>
>>>> To: "LTP list" <ltp-list@lists.sourceforge.net>
>>>> Sent: Wednesday, 29 May, 2013 10:58:47 AM
>>>> Subject: [LTP] [PATCH] shmget/shmget01.c: cleanup and attach SHM_NORESERVE to shmflg
>>>>
>>>>
>>>> 1. Remove useless comments
>>>>
>>>> 2. Revise code to follow ltp-code-style
>>>>
>>>> 3. Add SHM_NORESERVE to shmflg to test
>>>
>>> Can you add some description why you are adding this flag?
>>
>> Actually, we are trying to complete test cases and expand
>> the test scope of LTP.
>>
>> So, it is just for completeness of this case.
> 
> Would it be better to split the code-style fix and the functional/feature part?

Agree.

Coming V2 will make it.

Regards,
DAN LI
> 
> Caspar
> 



------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
[prev in list] [next in list] [prev in thread] [next in thread]