[prev in list] [next in list] [prev in thread] [next in thread]
List: ltp-list
Subject: Re: [LTP]
From: Godwin Gao <godwin.gao () hotmail ! com>
Date: 2010-08-23 9:14:07
Message-ID: SNT119-W194FB25225A64DF37C926C94820 () phx ! gbl
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Combining the patch for issue 1, this patch is fine.
Thanks,
Godwin Gao
> Date: Mon, 23 Aug 2010 01:17:03 -0700
> Subject: Re: [LTP] [PATCH]fix the at_deny01 failureţ
> From: yanegomi@gmail.com
> To: godwin.gao@hotmail.com
> CC: ltp-list@lists.sourceforge.net
>
> 2010/8/23 Godwin Gao <godwin.gao@hotmail.com>:
> > Retested the at_deny01 case, and found the same issue[2]. The below is the
> > test steps, if something wrong, please note me.
> >
> > 1. create a runtest/at file
> > root@godwin-desktop:/home/godwin/LTP_New/ltp-full-20100630# cat runtest/at
> > at_deny01 at_deny01
> > 2. fixed the issue[1]
> > 3. ./runltp -p -l a.txt -f at
> >
> > Seems it is a environment setup issue, test_user_1 does not have the
> > ${LTPROOT}/testcases/bin in its PATH.
> > Attached the log
>
> Ok, I see the issue now:
>
> ‘-’
> ‘-l’
> ‘--login’
> Make the shell a login shell. This means the following. Unset all
> environment variables except TERM, HOME, and SHELL (which are set as
> described above), and USER and LOGNAME (which are set, even for the
> super-user, as described above), and set PATH to a compiled-in default
> value. Change to user's home directory. Prepend ‘-’ to the shell's
> name, intended to make it read its login startup file(s).
>
> Note that it's a `precompiled' path (BSD explicitly calls this out
> as /bin:/usr/bin, but who knows what Linux sets this as).
> Here's a quick patch for this item; please let me know how it
> works in the negative case.
> Thanks,
> -Garrett
>
> PS The reason why I did this was to avoid environment tainting as
> setup_test says:
>
> # This is the workaround for a potential bug.
> # [Bug 468337] At Refuse to Work with Non-login Shell
> # https://bugzilla.redhat.com/show_bug.cgi?id=468337
> # As we are running in non-login shell now, we cannot run the script
> # by simply given it a relative path. Therefore, we copy it to test
> # users' home directories, and run it from there.
>
> because -m/-p would have done just that (besides... environment
> tainting just makes crud non-deterministic...).
[Attachment #5 (text/html)]
<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Tahoma
}
--></style>
</head>
<body class='hmmessage'>
Combining the patch for issue 1, this patch is \
fine.<br><br><br>Thanks,<br>Godwin Gao<br><br>> Date: Mon, 23 Aug 2010 01:17:03 \
-0700<br>> Subject: Re: [LTP] [PATCH]fix the at_deny01 failureţ<br>> From: \
yanegomi@gmail.com<br>> To: godwin.gao@hotmail.com<br>> CC: \
ltp-list@lists.sourceforge.net<br>> <br>> 2010/8/23 Godwin Gao \
<godwin.gao@hotmail.com>:<br>> > Retested the at_deny01 case, and found \
the same issue[2]. The below is the<br>> > test steps, if something wrong, \
please note me.<br>> ><br>> > 1. create a runtest/at file<br>> > \
root@godwin-desktop:/home/godwin/LTP_New/ltp-full-20100630# cat runtest/at<br>> \
> at_deny01 at_deny01<br>> > 2. fixed the issue[1]<br>> \
> 3. ./runltp -p -l a.txt -f at<br>> ><br>> > Seems it is a \
environment setup issue, test_user_1 does not have the<br>> > \
${LTPROOT}/testcases/bin in its PATH.<br>> > Attached the log<br>> <br>> \
Ok, I see the issue now:<br>> <br>> ‘-’<br>> ‘-l’<br>> ‘--login’<br>> \
Make the shell a login shell. This means the following. Unset all<br>> environment \
variables except TERM, HOME, and SHELL (which are set as<br>> described above), \
and USER and LOGNAME (which are set, even for the<br>> super-user, as described \
above), and set PATH to a compiled-in default<br>> value. Change to user's home \
directory. Prepend ‘-’ to the shell's<br>> name, intended to make it read its \
login startup file(s).<br>> <br>> Note that it's a `precompiled' path (BSD \
explicitly calls this out<br>> as /bin:/usr/bin, but who knows what Linux sets \
this as).<br>> Here's a quick patch for this item; please let me know how \
it<br>> works in the negative case.<br>> Thanks,<br>> -Garrett<br>> \
<br>> PS The reason why I did this was to avoid environment tainting as<br>> \
setup_test says:<br>> <br>> # This is the workaround for a potential \
bug.<br>> # [Bug 468337] At Refuse t o Work with Non-login Shell<br>> \
# https://bugzilla.redhat.com/show_bug.cgi?id=468337<br>> # As we are \
running in non-login shell now, we cannot run the script<br>> # by simply \
given it a relative path. Therefore, we copy it to test<br>> # users' home \
directories, and run it from there.<br>> <br>> because -m/-p would have done \
just that (besides... environment<br>> tainting just makes crud \
non-deterministic...).<br> </body> </html>
------------------------------------------------------------------------------
This SF.net email is sponsored by
Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic