[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ltp-list
Subject:    Re: [LTP] [PATCH] Multicast ping error message
From:       Subrata Modak <subrata () linux ! vnet ! ibm ! com>
Date:       2009-03-30 8:34:54
Message-ID: 1238401374.5188.13.camel () subratamodak ! linux ! ibm ! com
[Download RAW message or body]

On Thu, 2009-03-26 at 14:41 -0700, Vernon Mauery wrote:
> Subrata Modak wrote:
> > Hi Vernon,
> > 
> > On Wed, 2009-03-18 at 07:21 -0700, Vernon Mauery wrote:
> >> It has come to our attention that when running multicast tests that the
> >> multicast ping test assumes that all the machines on the network,
> >> including the machine getting tested, have multicast ping enabled.  This
> >> has not been the case since 2005 when multicast ping was disabled by
> >> default, mostly to inhibit ddos activity.  See this conversation for more
> >> details: https://bugzilla.redhat.com/show_bug.cgi?id=159367
> >>
> >> Now on all kernels, /proc/sys/net/icmp_echo_ignore_broadcasts is set to 1
> >> by default, thereby failing this test.  But the error message is wrong.
> >> Multicast is not disabled, only multicast ping.  This patch modifies the
> >> error message and tells that it is now normal to fail.
> >>
> >> --Vernon
> >>
> >> Signed-off-by: Vernon Mauery <vernux@us.ibm.com>

Thanks.

Regards--
Subrata

> >> Acked-by: Sripathi Kodi <sripathik@in.ibm.com>
> > 
> > This fails to apply. Can you please resend ??
> 
> Patch attached as well as inline, since inline didn't seem to work.
> I just re-rolled this from a newly updated CVS repo.
> 
> ------------------------
> 
> It has come to our attention that when running multicast tests that the
> multicast ping test assumes that all the machines on the network,
> including the machine getting tested, have multicast ping enabled.  This
> has not been the case since 2005 when multicast ping was disabled by
> default, mostly to inhibit ddos activity.  See this conversation for more
> details: https://bugzilla.redhat.com/show_bug.cgi?id=159367
> 
> Now on all kernels, /proc/sys/net/icmp_echo_ignore_broadcasts is set to 1
> by default, thereby failing this test.  But the error message is wrong.
> Multicast is not disabled, only multicast ping.  This patch modifies the
> error message and tells that it is now normal to fail.
> 
> --Vernon
> 
> Signed-off-by: Vernon Mauery <vernux@us.ibm.com>
> Acked-by: Sripathi Kodi <sripathik@in.ibm.com>
> 
> Index: testcases/network/multicast/mc_cmds/mc_cmds
> ===================================================================
> RCS file: /cvsroot/ltp/ltp/testcases/network/multicast/mc_cmds/mc_cmds,v
> retrieving revision 1.14
> diff -u -r1.14 mc_cmds
> --- a/testcases/network/multicast/mc_cmds/mc_cmds 21 Oct 2008 08:56:23 -0000      1.14
> +++ b/testcases/network/multicast/mc_cmds/mc_cmds 26 Mar 2009 21:35:56 -0000
> @@ -127,8 +127,7 @@
>      cat /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts | grep 1 > /dev/null
>      if [ $? -eq 0 ]
>      then
> -       echo "Multicast disabled on this system"
> -       exit
> +       end_testcase "Multicast ping disabled on this system (this is normal on post 2005 kernels)"
>      fi
> 
>      # Do the ping tests: Execute ping 224.0.0.1 - Verify that the proper
> 
> 
> > patching file testcases/network/multicast/mc_cmds/mc_cmds
> > Hunk #1 FAILED at 127.
> > 
> > Regards--
> > Subrata
> > 
> >> Index: testcases/network/multicast/mc_cmds/mc_cmds
> >> ===================================================================
> >> RCS file: /cvsroot/ltp/ltp/testcases/network/multicast/mc_cmds/mc_cmds,v
> >> retrieving revision 1.14
> >> diff -u -r1.14 mc_cmds
> >> --- testcases/network/multicast/mc_cmds/mc_cmds 21 Oct 2008 08:56:23 -0000      1.14
> >> +++ testcases/network/multicast/mc_cmds/mc_cmds 17 Mar 2009 20:06:20 -0000
> >> @@ -127,8 +127,7 @@
> >>       cat /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts | grep 1 > /dev/null
> >>       if [ $? -eq 0 ]
> >>       then
> >> -       echo "Multicast disabled on this system"
> >> -       exit
> >> +       end_testcase "Multicast ping disabled on this system (this is normal on post-2005 kernels)"
> >>       fi
> >>
> >>       # Do the ping tests: Execute ping 224.0.0.1 - Verify that the proper
> > 
> 


------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
[prev in list] [next in list] [prev in thread] [next in thread]