[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ltp-list
Subject:    Re: [LTP] [PATCH] fix wrong return value of inlined
From:       Subrata Modak <subrata () linux ! vnet ! ibm ! com>
Date:       2008-10-29 5:40:34
Message-ID: 1225258114.5072.37.camel () subratamodak ! linux ! ibm ! com
[Download RAW message or body]

I applied it already. Thanks.

Regards--
Subrata

On Fri, 2008-10-24 at 17:55 +0530, Nagesh Sharyathi wrote:
> Daniel
>    Excuse me for the delay. yes this patch fixes an issue in the test case.
> Thanks for pointing out.
> Subrata
>   Can you kindly apply the patch pointed by Daniel to the getcpu test case
> Thanks
> Sharyathi N
> 
> 
>                                                                            
>              Daniel Gollub                                                 
>              <dgollub@suse.de>                                             
>                                                                         To 
>              10/22/2008 06:31          Nagesh Sharyathi/India/IBM@IBMIN    
>              PM                                                         cc 
>                                        Subrata Modak                       
>                                        <subrata@linux.vnet.ibm.com>,       
>                                        ltp-list@lists.sf.net               
>                                                                    Subject 
>                                        Re: [LTP] [PATCH] fix wrong return  
>                                        value of inlined getcpu()           
>                                        test-function on non-i386           
>                                                                            
>                                                                            
>                                                                            
>                                                                            
>                                                                            
>                                                                            
> 
> 
> 
> 
> On Wednesday 22 October 2008 10:38:05 Nagesh Sharyathi wrote:
> > Daniel
> >       I will update you once I test it on other architecture, we have
> > noticed similar issue with CELL processors.
> > I am worried if we have opened up some more issues. Give me some time
> > Thanks
> > Sharyathi N
> 
> Could you try to run the testcase with CPU affinity to CPU0?
> 
> x86_64:~/ltp-full-20081022/:[1]#
> ./testcases/kernel/syscalls/getcpu/getcpu01
> getcpu01    1  FAIL  :  getcpu() Failed, errno=0:Success
> x86_64:~/ltp-full-20081022/:[1]# taskset -c 0
> ./testcases/kernel/syscalls/getcpu/getcpu01
> getcpu01    1  PASS  :  getcpu() returned proper cpuid:0, node id:0
> 
> Later one proofs the point that returning 0 of the getcpu() function is
> expected. Running this on a SMP system it's less likely it's running on
> CPU0 all the time ... so it fails randomly. Setting affinity to CPU0 lets
> the
> testcase pass since getcpu() will also return 0.
> 
> Maybe this helps on debugging - i have no access to Cell processors, but
> this
> should be Arch independent (expect i386).
> 
> It's really a trivial thing... just remove the return from the
> get_schedcpu() call...
> 
> best regards,
> Daniel
> 
> 


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
[prev in list] [next in list] [prev in thread] [next in thread]