[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ltp-list
Subject:    Re: [LTP] [PATCH] fix wrong return value of inlined
From:       Nagesh Sharyathi <sharyathi () in ! ibm ! com>
Date:       2008-10-22 8:50:05
Message-ID: OF9E7B8361.05A46871-ON652574EA.002EF424-652574EA.002F3A94 () in ! ibm ! com
[Download RAW message or body]

Daniel
      I will update you once I test it on other architecture, we have
noticed similar issue with CELL processors.
I am worried if we have opened up some more issues. Give me some time
Thanks
Sharyathi N




                                                                           
             Subrata Modak                                                 
             <subrata@linux.vn                                             
             et.ibm.com>                                                To 
                                       Nagesh Sharyathi/India/IBM@IBMIN    
             10/21/2008 06:51                                           cc 
             PM                        ltp-list@lists.sf.net, Daniel       
                                       Gollub <dgollub@suse.de>            
                                                                   Subject 
             Please respond to         Re: [LTP] [PATCH] fix wrong return  
                  subrata              value of inlined getcpu()           
                                       test-function on non-i386           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           




On Mon, 2008-10-20 at 16:04 +0200, Daniel Gollub wrote:
> Hi,
>
> the getcpu() test-function returns the current scheduled CPU id of the
> test-process for archiectures expect i386, which is not the intended
return
> value of a syscall test.
>
> Attachted patch returns instead 0, for non-i386 ARCH and
__GLIBC_PREREQ(2,6).
>
> Tested on x86_64.
>
> Signed-off-by: Daniel Gollub <dgollub@suse.de>

Waiting for Sharyathi´s comments on this.

Regards--
Subrata

>
> ---
>  testcases/kernel/syscalls/getcpu/getcpu01.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: ltp-full-20081017/testcases/kernel/syscalls/getcpu/getcpu01.c
> ===================================================================
> --- ltp-full-20081017.orig/testcases/kernel/syscalls/getcpu/getcpu01.c
> +++ ltp-full-20081017/testcases/kernel/syscalls/getcpu/getcpu01.c
> @@ -165,7 +165,7 @@ static inline int getcpu(unsigned *cpu_i
>            #if defined(__i386__)
>                        return syscall(318, cpu_id,node_id,cache_struct);
>            #elif __GLIBC_PREREQ(2,6)
> -                      return *cpu_id = sched_getcpu();
> +                      *cpu_id = sched_getcpu();
>            #endif
>            return 0;
>  }
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
challenge
> Build the coolest Linux based applications with Moblin SDK & win great
prizes
> Grand prize is a trip for two to an Open Source event anywhere in the
world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list




-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[prev in list] [next in list] [prev in thread] [next in thread]