[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ltp-list
Subject:    [LTP] [ ltp-Bugs-1671695 ] Check return codes everywhere
From:       "SourceForge.net" <noreply () sourceforge ! net>
Date:       2007-03-28 8:23:27
Message-ID: E1HWTRH-0000HC-Nr () sc8-sf-web24 ! sourceforge ! net
[Download RAW message or body]

Bugs item #1671695, was opened at 2007-03-01 14:06
Message generated for change (Comment added) made by elfring
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=103382&aid=1671695&group_id=3382

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Tools
Group: Miscellaneous
> Status: Open
> Resolution: Accepted
Priority: 5
Private: No
Submitted By: Markus Elfring (elfring)
> Assigned to: mreed (mreed10)
Summary: Check return codes everywhere

Initial Comment:
Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "write" like in the \
function "wlog_record_write" and from "lseek" in the function "wlog_scan_backward"? \
http://ltp.cvs.sourceforge.net/ltp/ltp/lib/write_log.c?revision=1.7&view=markup

----------------------------------------------------------------------

> Comment By: Markus Elfring (elfring)
Date: 2007-03-28 10:23

Message:
Logged In: YES 
user_id=572001
Originator: YES

Thanks for this fix.

1. Would you like to detect every error situation as early as possible?

2. I see more candidates for similar updates to avoid unchecked function
calls.
Example:
http://ltp.cvs.sourceforge.net/ltp/ltp/lib/tst_tmpdir.c?revision=1.11&view=markup
- close()
- printf()
- scanf()
- strdup()
- unlink()

3. Would you like to improve the source code with the help of the tool
"http://splint.org/"?

----------------------------------------------------------------------

Comment By: Subrata (subrata_modak)
Date: 2007-03-28 06:05

Message:
Logged In: YES 
user_id=1737361
Originator: NO

Added more error handling code.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=103382&aid=1671695&group_id=3382

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list


[prev in list] [next in list] [prev in thread] [next in thread]