[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ltp-list
Subject:    Re: [LTP] Don't hardcode constants in fchownat01
From:       Jeff Bailey <jbailey () raspberryginger ! com>
Date:       2006-08-27 22:34:04
Message-ID: 20060827223404.GB10455 () titanium ! v3 ! ca
[Download RAW message or body]

On Sun, Aug 27, 2006 at 06:23:30PM -0400, Mike Frysinger wrote:
> On Sunday 27 August 2006 18:15, Jeff Bailey wrote:
> > Why?  The common header that defines them is asm/unistd.h, pulled in
> > through sys/syscall.h.
> 
> even better would be to just use the symbol from the system libc ... but that 
> has the same problems as using outdated kernel headers

Right.  That's why I pulled them in through sys/syscall.h rather than
through asm/unistd.h in the patches.

> > I think it's a mistake to hardcode these values when it's trivial to
> > install the right headers when a new kernel is installed, especially
> > given that (I believe) all major distros have now switched to a
> > standardised header set.
> 
> that's why you make them a fallback, not the default

Is the ifdef solution that I proposed fine?  I don't see any reason to
hardcode the values.  If someone has an old kernel, these tests won't
pass anyway.  That way there's no duplication of values anywhere, and I
think it meets both cases.  If yes, I'll cook that up as a patch
tomorrow.

Tks,
Jeff Bailey

-- 
I do not agree with a word you say, but I will defend to the death your
right to say it. 
 - Voltaire

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
[prev in list] [next in list] [prev in thread] [next in thread]