[prev in list] [next in list] [prev in thread] [next in thread]
List: lse-tech
Subject: [Lse-tech] Re: Bug in last night's bk test
From: Badari Pulavarty <pbadari () us ! ibm ! com>
Date: 2002-09-23 23:37:08
[Download RAW message or body]
Ok !! Making direct-io code use bio_add_page() is little tricky.
We operate on the same page multiple times to update the length of
the IO (in case of raw device). I will look at it closely.
Thanks,
Badari
> Current bitkeeper has
>
> #define BIO_MAX_PAGES (256)
>
> That's a megabyte. It works fine with mpage.c. But direct-io.c
> is still using BIO_MAX_PAGES. It really is building 1 megabyte
> BIOs, which will break just about every device out there.
>
> I think we just ask Linus to do the below until we get it fixed up?
>
>
> --- 2.5.38-bk2/fs/direct-io.c~direct-io-size Mon Sep 23 16:12:25 2002
> +++ 2.5.38-bk2-akpm/fs/direct-io.c Mon Sep 23 16:12:47 2002
> @@ -26,7 +26,7 @@
> * The largest-sized BIO which this code will assemble, in bytes. Set this
> * to PAGE_SIZE if your drivers are broken.
> */
> -#define DIO_BIO_MAX_SIZE BIO_MAX_SIZE
> +#define DIO_BIO_MAX_SIZE (16*1024)
>
> /*
> * How many user pages to map in one call to get_user_pages(). This determines
>
> .
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Lse-tech mailing list
Lse-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lse-tech
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic