[prev in list] [next in list] [prev in thread] [next in thread] 

List:       logback-dev
Subject:    [logback-dev] [JIRA] (LOGBACK-910) AsyncAppenderBase swallows InterruptedException
From:       "Will Gorman (JIRA)" <noreply-jira () qos ! ch>
Date:       2015-10-08 16:50:39
Message-ID: JIRA.11765.1382445101000.42.1444323039577 () tao
[Download RAW message or body]

[Attachment #2 (text/html)]

<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and \
(-webkit-min-device-pixel-ratio: 2) {  #email-body { min-width: 30em !important; }
    #email-page { padding: 8px !important; }
    #email-banner { padding: 8px 8px 0 8px !important; }
    #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
    #email-fields { padding: 0 8px 8px 8px !important; }
    #email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" \
style="background-color:#f0f0f0;color:#000000;width:100%;">  <tr valign="top">
        <td id="email-page" style="padding:16px !important;">
            <table align="center" border="0" cellpadding="0" cellspacing="0" \
style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">  \
<tr valign="top">  <td bgcolor="#003366" \
style="background-color:#003366;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img \
src="http://jira.qos.ch/s/en_USx01s37-418945332/850/27/_/jira-logo-scaled.png" alt="" \
style="vertical-align:top;" /></td>  </tr><tr valign="top">
    <td id="email-banner" style="padding:32px 32px 0 32px;">

                
        
        
            <table align="left" border="0" cellpadding="0" cellspacing="0" \
width="100%" style="width:100%;">  <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
  <img id="email-avatar" src="http://jira.qos.ch/secure/useravatar?avatarId=10122" \
alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px \
                16px 0;" />
                        <div id="email-action" style="padding: 0 0 8px \
0;font-size:12px;line-height:18px;">  <a class="user-hover" rel="willgorman" \
id="email_willgorman" \
href="http://jira.qos.ch/secure/ViewProfile.jspa?name=willgorman" \
style="color:#326ca6;">Will Gorman</a>  commented on <img \
src="http://jira.qos.ch/images/icons/issuetypes/bug.png" height="16" width="16" \
border="0" align="absmiddle" alt="Bug"> <a \
style='color:#326ca6;text-decoration:none;' \
href='http://jira.qos.ch/browse/LOGBACK-910'>LOGBACK-910</a>  </div>
                        <div id="email-summary" \
style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">  <a \
style='color:#326ca6;text-decoration:none;' \
href='http://jira.qos.ch/browse/LOGBACK-910'><strong>AsyncAppenderBase swallows \
InterruptedException</strong></a>  </div>
                    </td>
    </tr>
</table>
    </td>
</tr>
<tr valign="top">
    <td id="email-fields" style="padding:0 32px 32px 32px;">
        <table border="0" cellpadding="0" cellspacing="0" \
style="padding:0;text-align:left;width:100%;" width="100%">  <tr valign="top">
                <td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
                <td>
                    <table border="0" cellpadding="0" cellspacing="0" width="100%">
                        <tr valign="top">
    <td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 \
0 16px 0;width:100%;">  <div class="comment-block" \
style="background-color:#edf5ff;border:1px solid \
#dddddd;color:#000000;padding:12px;"><p>I've got a question about the fix for this \
issue.  It looks like it prevents any log messages from being written from an \
interrupted thread.  For example:</p>

<div class="code panel" style="border-width: 1px;"><div class="codeContent \
panelContent"> <pre class="code-java"><span class="code-keyword">try</span> {
  Connection connection = dataSource.getConnection();
} <span class="code-keyword">catch</span> (SQLException e) {
  LOGGER.error(<span class="code-quote">"Oh no!"</span>)
  LOGGER.error(<span class="code-quote">"This is bad"</span>)
}
</pre>
</div></div>

<p>In the case where the SQLException is raised as the result of the thread being \
interrupted while getting the Connection then neither of those messages are written \
when using logback-classic-1.1.4-SNAPSHOT.  The call to blockingQueue.put catches the \
InterruptedException each time.  With versions &lt; 1.1.4-SNAPSHOT the first error \
message is lost but the second one shows up because the first call cleared the \
interrupt.  It's definitely better to preserve the interrupt flag but halting all \
                logging doesn't seem ideal.  Would this be considered a \
                bug?</p></div>
        <div style="color:#505050;padding:4px 0 0 0;">                </div>
    </td>
</tr>
                    </table>
                </td>
            </tr>
        </table>
    </td>
</tr>













            </table>
        </td><!-- End #email-page -->
    </tr>
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: \
0 16px 16px 16px;text-align:center;">  This message is automatically generated by \
                JIRA.<br />
            If you think it was sent incorrectly, please contact your JIRA \
                administrators<br />
            For more information on JIRA, see: <a style='color:#326ca6;' \
href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
  </td>
    </tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->


[Attachment #3 (text/plain)]

_______________________________________________
logback-dev mailing list
logback-dev@qos.ch
http://mailman.qos.ch/mailman/listinfo/logback-dev

[prev in list] [next in list] [prev in thread] [next in thread]