[prev in list] [next in list] [prev in thread] [next in thread] 

List:       logback-dev
Subject:    [logback-dev] [Bug 96] Make ContextSelectors truely
From:       bugzilla-daemon () pixie ! qos ! ch
Date:       2007-09-18 21:12:09
Message-ID: 20070918211209.8B3578769C () pixie ! qos ! ch
[Download RAW message or body]

http://bugzilla.qos.ch/show_bug.cgi?id=96





------- Comment #2 from lars@koedderitzsch.net  2007-09-18 23:12 -------
The change looks good, thanks for you very quick response on this.
I'll try the change in the next week (we launch our product later this week).
Is there a place where I can grab the latest nightly, or do I need to build
from the repository?

As I understand it from the code I need to provide the fully qualified
classname of my custom ContextSelector through the "logback.ContextSelector"
system property.
Further - besides implementing the ContextSelector interface - the custom
ContextSelector class need an constructor that takes a LoggerContext argument.

In this point I think it would be more clear to ContextSelector implementors,
if the initialization done through the constructor could be pulled into the
ContextSelector interface, e.g.
 public void initialize(LoggerContext defaultContext);

Otherwise I see people implementing ContextSelector and try to use it and fail
because their implementation does not include the expected constructor in the
first try.
Exposing the initialization needs through the ContextSelector interface would
help in this point.


-- 
Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
logback-dev mailing list
logback-dev@qos.ch
http://qos.ch/mailman/listinfo/logback-dev
[prev in list] [next in list] [prev in thread] [next in thread]