[prev in list] [next in list] [prev in thread] [next in thread] 

List:       log4j-dev
Subject:    [jira] [Commented] (LOG4J2-673) plugin preloading fails in shaded jar files
From:       "ASF GitHub Bot (JIRA)" <jira () apache ! org>
Date:       2016-04-27 2:48:12
Message-ID: JIRA.12722580.1403208991000.42410.1461725292984 () Atlassian ! JIRA
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/LOG4J2-673?page=com.atlassian.jira.plugin. \
system.issuetabpanels:comment-tabpanel&focusedCommentId=15259438#comment-15259438 ] 

ASF GitHub Bot commented on LOG4J2-673:
---------------------------------------

Github user jvz commented on the pull request:

    https://github.com/apache/logging-log4j2/pull/4#issuecomment-214954347
  
    Shit, I closed this by accident. Meant to close #5.


> plugin preloading fails in shaded jar files
> -------------------------------------------
> 
> Key: LOG4J2-673
> URL: https://issues.apache.org/jira/browse/LOG4J2-673
> Project: Log4j 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0-rc2, 2.1
> Reporter: mck
> Assignee: Matt Sicker
> Priority: Critical
> Labels: annotations, compiler, plugins
> Attachments: 0002-LOG4J2-673-plugin-preloading-fails-in-shaded-jar-fil.patch, \
> 0005-LOG4J2-673-plugin-preloading-fails-in-shaded-jar-fil.patch 
> 
> Support for plugin preloading through the standard javax.annotation.processing tool \
> was adding in LOG4J2-595 But the plugin processor always creates and stores the \
> processed "Plugin" annotated classes into the same file. This works fine when the \
> classpath consists of individual jar files, but fails when shaded jar files are \
> used. A tested fix exists at \
> https://github.com/finn-no/logging-log4j2/tree/bugfix/LOG4J2-673 There's also a \
> github pull request and a manual diff attached. (I can clean up anything not used \
> afterwards) The fix saves the dat file in a location under META-INF that matches \
> the shared package all the processed plugins are found under. The package attribute \
> in the config file is then used so that multiple dat files can be loaded at \
> runtime. This means that the package attribute is no longer deprecated.
> This has been tested against \
> https://github.com/finn-no/log4j2-logstash-jsonevent-layout



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]