[prev in list] [next in list] [prev in thread] [next in thread]
List: log4j-dev
Subject: Re: discuss [VOTE] Log4j 2.0.1 candidate 1
From: Remko Popma <remko.popma () gmail ! com>
Date: 2014-07-30 15:27:50
Message-ID: CAAFrFhQVY6rUeENcwgBwGVyFzD_4c=V3Xzmqfdzop29Q=G3YVw () mail ! gmail ! com
[Download RAW message or body]
As long as we fix the release notes contents manually in the announcement
email, these are not showstoppers, are they?
On Thu, Jul 31, 2014 at 12:23 AM, Ralph Goers <ralph.goers@dslextreme.com>
wrote:
> I told you the wiki release page needed a few updates :-).
>
> The release notes are what are used to send the release announcement. So
> when the announcement email is sent out the changes noted below need to be
> made to it. The wiki needs to be updated to say that announcement.vm needs
> to be reviewed and updated appropriately.
>
> I think this was pointed out when Nick did the release. It is a bit of a
> PITA to have to update that for every release and keeping track of who
> signed which release is going to be a problem. I think the ASF is looking
> into a more generic code signing solution - or at least I think I recall
> reading about that.
>
> Ralph
>
> On Jul 30, 2014, at 7:57 AM, Remko Popma <remko.popma@gmail.com> wrote:
>
> +1 Artifacts look good, site looks good.
>
> Minor issues found (no showstoppers IMO):
>
> Artifacts
> ---------
> log4j-distribution-2.0.1-bin.zip/apache-log4j-2.0.1-bin/RELEASE-NOTES.txt
> "This is the first GA release, after thirteen prior releases over the last
> 4 years.
>
> ?
>
> Changes in this release..."
>
> -> Should be "...the second GA release..."
> -> The question mark "?" should probably be "Bug fixes and enhancements"
>
>
> Site
> ----
> Download page: "Apache Log4j 2 is signed by Ralph Goers B3D8E1BA"
> -> Is this correct for 2.0.1?
>
> Project Info > Dependency Convergence: logj2-perf uses disruptor-3.2.1,
> but log4j-core uses disruptor-3.3.0.
> (Not an issue since log4j-perf is not a distribution artifact.)
>
>
> Javadoc: many package docs mention "Log4j 2.0". E.g.
>
> http://people.apache.org/~mattsicker/log4j/2.0.1/log4j-api/apidocs/index.html
> Sometime in the future we will release version 2.1, 2.2, etc.
> Should we update all Javadoc pages to "Log4j 2" to future-proof them?
>
> Similarly, the FAQ page mentions "the Log4j 2.0 implementation" and "the
> Log4j 2.0 API".
> We should probably change this to "the Log4j 2 implementation" and "the
> Log4j 2 API".
>
> Manual > Introduction (index.html)
> "The latest log4j version, including full-source code, class files and
> documentation can be found at
> http://logging.apache.org/log4j/2.0/index.html."
> -> We should change that link to
> http://logging.apache.org/log4j/2.x/index.html
> (It looks like 2.0 and 2.x both work as URLs.)
>
> Manual > Log4j 1.x Migration also has a few mentions of "2.0".
> Manual > Configuration page has one mention of "2.0".
> Manual > JMX has six places where log4j-api-2.0.jar etc are mentioned.
> -> Can we make these variables to they change with the ${project.version}?
> Manual > Custom Log Levels has two places where log4j-core.2.0.jar is
> mentioned.
> -> Can we make these variables to they change with the ${project.version}?
>
> Manual > Layouts > PatternLayout, %d pattern examples:
> %d{HH:mm:ss}{GMT+0} 18:34:02,781 <- this does not look right? The result
> has millis instead of timezone...
>
> Manual > Architecture > LoggerConfig > Log Levels: (we may want to rewrite
> the text below)
> The set of possible levels includes TRACE, DEBUG, INFO, WARN, ERROR, and
> FATAL.
> Note that in Log4j 2, the Level is an Enum and cannot be sub-classed.
> Users who desire more granularity are encouraged to use Markers instead.
>
> Manual > Extending Log4j > ContextSelector: missing
> AsyncLoggerContextSelector
>
>
>
> On Wed, Jul 30, 2014 at 10:33 AM, Matt Sicker <boards@gmail.com> wrote:
>
>> This is a vote to release Log4j 2.0.1, the first bug fix release of the
>> 2.0 branch of Log4j 2.
>>
>> Please test and cast your votes.
>> [] +1, release the artifacts
>> [] -1, don't release because...
>>
>> The vote will remain open for 72 hours (or more if required). Note that
>> binding votes, as usual, are done by PMC members. Non-binding votes are
>> welcome from anyone and are always welcome.
>>
>> This is my first time acting as an RM, so if there are any issues with
>> this, please let me know as soon as possible! If you don't already have my
>> GPG key, it's key ID FA1C814D which is available on all the public GPG
>> servers. Otherwise, you can download it from my Apache site at: <
>> http://people.apache.org/~mattsicker/FA1C814D.asc>
>>
>> New features:
>> o LOG4J2-725: Added WebLoggerContextUtils class to log4j-web for helper
>> methods useful for asynchronous servlets.
>> o LOG4J2-710: Added documentation for Custom Levels and Custom Loggers.
>>
>> Fixed Bugs:
>> o LOG4J2-744: Avoid unnecessary Clock calls when TimestampMessage is
>> logged. Thanks to Scott Harrington.
>> o LOG4J2-704: Improved error message if configuration file not found.
>> o LOG4J2-750: Webapp configuration page has incorrect class name. Thanks
>> to Mike Calmus.
>> o LOG4J2-749: Retain the default date pattern after fixing the ISO8601
>> pattern. Thanks to Scott Harrington.
>> o LOG4J2-670: DatePatternConverter ISO8601_PATTERN now conforms to
>> ISO8601.
>> o LOG4J2-741: Reinstate the package configuration attribute for
>> discovering custom plugins.
>> o LOG4J2-742: XInclude not working with relative path. Thanks to Pascal
>> Chollet.
>> o LOG4J2-740: Fixed typo in webapp manual regarding sample web.xml file.
>> Thanks to Kosta Krauth.
>> o LOG4J2-738: RollingFileManager deadlock if async action thread fails
>> to start. Thanks to Timothy Stack.
>> o LOG4J2-736: Fixed log4j-bom so that it won't specify a default scope
>> on any third party dependencies.
>> o LOG4J2-735: Fixed log4j-bom so that it won't interfere with spring-bom
>> and others.
>> o LOG4J2-731: Updated documentation regarding extensions to
>> LoggerContextFactory and Log4j 2 providers.
>> o LOG4J2-373: Fixed ClassLoader issues in loading Log4j providers in an
>> OSGi environment.
>> o LOG4J2-719: Correctly handle NetworkOnMainThreadException thrown on
>> Android during Log4j2 initialization.
>> o LOG4J2-716: Automatically disable log4j JMX when detecting we are
>> running on Android.
>> o LOG4J2-657: Fixed AbstractDatabaseManager to close connection on
>> writeInternal error. Thanks to Stefan Wehner.
>> o LOG4J2-713: Android: java.lang.VerifyError:
>> org/apache/logging/log4j/core/util/Closer Thanks to Nelson Melina.
>> o LOG4J2-703: Android: Could not find class
>> 'javax.naming.InitialContext', referenced from method
>> org.apache.logging.log4j.core.lookup.JndiLookup.lookup. Thanks to Nelson
>> Melina.
>>
>> Tag:
>> http://svn.apache.org/repos/asf/logging/log4j/log4j2/tags/log4j-2.0.1/
>>
>> SVN revision: 1614534
>>
>> Web Site: http://people.apache.org/~mattsicker/log4j/2.0.1/
>>
>> Artifacts:
>> https://repository.apache.org/content/repositories/orgapachelogging-1005/
>>
>> You may download all the artifacts by executing:
>>
>> wget -e robots=off --cut-dirs=3 -r -p -np --no-check-certificate
>> https://repository.apache.org/content/repositories/orgapachelogging-1005/
>>
>> --
>> Matt Sicker <boards@gmail.com>
>>
>
>
>
[Attachment #3 (text/html)]
<div dir="ltr">As long as we fix the release notes contents manually in the \
announcement email, these are not showstoppers, are they?</div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jul 31, 2014 at 12:23 \
AM, Ralph Goers <span dir="ltr"><<a href="mailto:ralph.goers@dslextreme.com" \
target="_blank">ralph.goers@dslextreme.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div style="word-wrap:break-word"><div>I told you the wiki \
release page needed a few updates :-).</div><div><br></div><div> The release notes \
are what are used to send the release announcement. So when the announcement email is \
sent out the changes noted below need to be made to it. The wiki needs to be \
updated to say that announcement.vm needs to be reviewed and updated \
appropriately.</div> <div><br></div><div>I think this was pointed out when Nick did \
the release. It is a bit of a PITA to have to update that for every release and \
keeping track of who signed which release is going to be a problem. I think the ASF \
is looking into a more generic code signing solution - or at least I think I recall \
reading about that.</div> <div><br></div><div>Ralph</div><br><div><div>On Jul 30, \
2014, at 7:57 AM, Remko Popma <<a href="mailto:remko.popma@gmail.com" \
target="_blank">remko.popma@gmail.com</a>> wrote:</div><br><blockquote \
type="cite"><div dir="ltr"> +1 Artifacts look good, site looks \
good.<div><br></div><div>Minor issues found (no showstoppers \
IMO):</div><div><br></div><div><div>Artifacts</div><div>---------</div><div>log4j-distribution-2.0.1-bin.zip/apache-log4j-2.0.1-bin/RELEASE-NOTES.txt</div>
<div>"This is the first GA release, after thirteen prior releases over the last \
4 years.</div><div><br></div><div>?</div><div><br></div><div>Changes in this \
release..."</div><div><br></div><div>-> Should be "...the second GA \
release..."</div>
<div>-> The question mark "?" should probably be "Bug fixes and \
enhancements"</div><div><br></div><div><br></div><div>Site</div><div>----</div><div>Download \
page: "Apache Log4j 2 is signed by Ralph Goers B3D8E1BA"</div>
<div>-> Is this correct for 2.0.1?</div><div><br></div><div>Project Info > \
Dependency Convergence: logj2-perf uses disruptor-3.2.1, but log4j-core uses \
disruptor-3.3.0.</div><div>(Not an issue since log4j-perf is not a distribution \
artifact.)</div>
<div><br></div><div><br></div><div>Javadoc: many package docs mention "Log4j \
2.0". E.g.</div><div><a \
href="http://people.apache.org/~mattsicker/log4j/2.0.1/log4j-api/apidocs/index.html" \
target="_blank">http://people.apache.org/~mattsicker/log4j/2.0.1/log4j-api/apidocs/index.html</a></div>
<div>Sometime in the future we will release version 2.1, 2.2, etc.</div><div>Should \
we update all Javadoc pages to "Log4j 2" to future-proof \
them?</div><div><br></div><div>Similarly, the FAQ page mentions "the Log4j 2.0 \
implementation" and "the Log4j 2.0 API".</div>
<div>We should probably change this to "the Log4j 2 implementation" and \
"the Log4j 2 API".</div><div><br></div><div>Manual > Introduction \
(index.html)</div><div>"The latest log4j version, including full-source code, \
class files and </div>
<div> documentation can be found at <a \
href="http://logging.apache.org/log4j/2.0/index.html" \
target="_blank">http://logging.apache.org/log4j/2.0/index.html</a>."</div><div>-> \
We should change that link to <a \
href="http://logging.apache.org/log4j/2.x/index.html" \
target="_blank">http://logging.apache.org/log4j/2.x/index.html</a></div>
<div> (It looks like 2.0 and 2.x both work as \
URLs.)</div><div><br></div><div>Manual > Log4j 1.x Migration also has a few \
mentions of "2.0".</div><div>Manual > Configuration page has one mention \
of "2.0".</div>
<div>Manual > JMX has six places where log4j-api-2.0.jar etc are mentioned. \
</div><div><span style="white-space:pre-wrap"> </span>-> Can we make these \
variables to they change with the ${project.version}?</div> <div>Manual > Custom \
Log Levels has two places where log4j-core.2.0.jar is mentioned.</div><div><span \
style="white-space:pre-wrap"> </span>-> Can we make these variables to they \
change with the ${project.version}?</div>
<div><br></div><div>Manual > Layouts > PatternLayout, %d pattern \
examples:</div><div>%d{HH:mm:ss}{GMT+0}<span \
style="white-space:pre-wrap"> </span>18:34:02,781 <- this does not look right? The \
result has millis instead of timezone...</div>
<div><br></div><div>Manual > Architecture > LoggerConfig > Log Levels: (we \
may want to rewrite the text below)</div><div>The set of possible levels includes \
TRACE, DEBUG, INFO, WARN, ERROR, and FATAL.</div><div> Note that in Log4j 2, the \
Level is an Enum and cannot be sub-classed.</div> <div>Users who desire more \
granularity are encouraged to use Markers instead.</div><div><br></div><div>Manual \
> Extending Log4j > ContextSelector: missing \
AsyncLoggerContextSelector</div><div><br></div></div></div> <div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, Jul 30, 2014 at 10:33 AM, Matt Sicker <span \
dir="ltr"><<a href="mailto:boards@gmail.com" \
target="_blank">boards@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div dir="ltr"><div>This is a vote to release Log4j 2.0.1, the first bug fix release \
of the 2.0 branch of Log4j 2.</div><div><br></div><div>Please test and cast your \
votes.</div><div>[] +1, release the artifacts</div><div>
[] -1, don't release because...</div><div><br></div><div>The vote will remain \
open for 72 hours (or more if required). Note that binding votes, as usual, are done \
by PMC members. Non-binding votes are welcome from anyone and are always \
welcome.</div>
<div><br></div><div>This is my first time acting as an RM, so if there are any issues \
with this, please let me know as soon as possible! If you don't already have my \
GPG key, it's key ID FA1C814D which is available on all the public GPG servers. \
Otherwise, you can download it from my Apache site at: <<a \
href="http://people.apache.org/~mattsicker/FA1C814D.asc" \
target="_blank">http://people.apache.org/~mattsicker/FA1C814D.asc</a>></div>
<div><br></div><div><div>New features:</div><div>o LOG4J2-725: Added \
WebLoggerContextUtils class to log4j-web for helper methods useful for asynchronous \
servlets. </div><div>o LOG4J2-710: Added documentation for Custom Levels and \
Custom Loggers. </div>
<div><br></div><div>Fixed Bugs:</div><div>o LOG4J2-744: Avoid unnecessary Clock \
calls when TimestampMessage is logged. Thanks to Scott Harrington. </div><div>o \
LOG4J2-704: Improved error message if configuration file not found. </div>
<div>o LOG4J2-750: Webapp configuration page has incorrect class name. Thanks to \
Mike Calmus. </div><div>o LOG4J2-749: Retain the default date pattern after fixing \
the ISO8601 pattern. Thanks to Scott Harrington. </div>
<div>o LOG4J2-670: DatePatternConverter ISO8601_PATTERN now conforms to ISO8601. \
</div><div>o LOG4J2-741: Reinstate the package configuration attribute for \
discovering custom plugins. </div><div>o LOG4J2-742: XInclude not working with \
relative path. Thanks to Pascal Chollet. </div>
<div>o LOG4J2-740: Fixed typo in webapp manual regarding sample web.xml file. \
Thanks to Kosta Krauth. </div><div>o LOG4J2-738: RollingFileManager deadlock if \
async action thread fails to start. Thanks to Timothy Stack. </div>
<div>o LOG4J2-736: Fixed log4j-bom so that it won't specify a default scope on \
any third party dependencies. </div><div>o LOG4J2-735: Fixed log4j-bom so that it \
won't interfere with spring-bom and others. </div>
<div>o LOG4J2-731: Updated documentation regarding extensions to \
LoggerContextFactory and Log4j 2 providers. </div><div>o LOG4J2-373: Fixed \
ClassLoader issues in loading Log4j providers in an OSGi environment. </div><div>
o LOG4J2-719: Correctly handle NetworkOnMainThreadException thrown on Android \
during Log4j2 initialization. </div><div>o LOG4J2-716: Automatically disable log4j \
JMX when detecting we are running on Android. </div><div>
o LOG4J2-657: Fixed AbstractDatabaseManager to close connection on writeInternal \
error. Thanks to Stefan Wehner. </div> <div>o LOG4J2-713: Android: \
java.lang.VerifyError: org/apache/logging/log4j/core/util/Closer Thanks to Nelson \
Melina. </div><div>o LOG4J2-703: Android: Could not find class \
'javax.naming.InitialContext', referenced from method \
org.apache.logging.log4j.core.lookup.JndiLookup.lookup. Thanks to Nelson Melina. \
</div>
<div><br></div><div>Tag: <a \
href="http://svn.apache.org/repos/asf/logging/log4j/log4j2/tags/log4j-2.0.1/" \
target="_blank">http://svn.apache.org/repos/asf/logging/log4j/log4j2/tags/log4j-2.0.1/</a></div></div><div><br></div>
<div>SVN revision: 1614534</div>
<div><br></div><div>Web Site: <a \
href="http://people.apache.org/~mattsicker/log4j/2.0.1/" \
target="_blank">http://people.apache.org/~mattsicker/log4j/2.0.1/</a></div><div><br></div>Artifacts: \
<a href="https://repository.apache.org/content/repositories/orgapachelogging-1005/" \
target="_blank">https://repository.apache.org/content/repositories/orgapachelogging-1005/</a><div>
<br></div><div>You may download all the artifacts by \
executing:</div><div><br></div><div>wget -e robots=off --cut-dirs=3 -r -p -np \
--no-check-certificate <a \
href="https://repository.apache.org/content/repositories/orgapachelogging-1005/" \
target="_blank">https://repository.apache.org/content/repositories/orgapachelogging-1005/</a><span \
class="HOEnZb"><font color="#888888"><span><font color="#888888"><br clear="all">
<div><br></div>-- <br>Matt Sicker <<a href="mailto:boards@gmail.com" \
target="_blank">boards@gmail.com</a>> \
</font></span></font></span></div></div><span class="HOEnZb"><font color="#888888"> \
</font></span></blockquote></div><span class="HOEnZb"><font \
color="#888888"><br></font></span></div> \
</blockquote></div><br></div></blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic