[prev in list] [next in list] [prev in thread] [next in thread]
List: log4j-dev
Subject: Re: Unit test failures
From: Ralph Goers <ralph.goers () dslextreme ! com>
Date: 2014-04-27 20:15:35
Message-ID: E2AB9D57-25A4-42E9-A6C7-2A91AFEDBA52 () dslextreme ! com
[Download RAW message or body]
I thought they all did - or it used to be in the parent pom.
Ralph
On Apr 27, 2014, at 12:57 PM, Matt Sicker <boards@gmail.com> wrote:
> Done. Looks like any jar-type project needs to include the maven-bundle-plugin in \
> their build section.
> <plugin>
> <groupId>org.apache.felix</groupId>
> <artifactId>maven-bundle-plugin</artifactId>
> </plugin>
>
>
>
> On 27 April 2014 14:55, Matt Sicker <boards@gmail.com> wrote:
> On it.
>
>
> On 27 April 2014 14:48, Ralph Goers <ralph.goers@dslextreme.com> wrote:
> OK, but now the Flume samples are failing with the same error. Do you think you \
> could run the full build and get it to work?
> Ralph
>
> On Apr 27, 2014, at 12:40 PM, Matt Sicker <boards@gmail.com> wrote:
>
> > Fixed it.
> >
> >
> > On 27 April 2014 14:38, Matt Sicker <boards@gmail.com> wrote:
> > Now that's a weird one. I'll figure that out right after I finish running the \
> > log4j-core unit tests before a new commit.
> >
> > On 27 April 2014 14:30, Ralph Goers <ralph.goers@dslextreme.com> wrote:
> > <sigh>
> >
> > Now the build is failing in the taglib project due to a missing MANIFEST.MF, \
> > which I find unusual because the jar plugin normally creates that.
> > Ralph
> >
> > On Apr 26, 2014, at 10:51 PM, Ralph Goers <ralph.goers@dslextreme.com> wrote:
> >
> > > FileOutputTest was failing because the status level was changed to OFF and the \
> > > test is expecting status logs to be written to a file. I’m not sure how why \
> > > this commit was ever done since a “mvn clean install” would have failed. Let \
> > > me reiterate one more time. If the unit tests fail don’t commit - you did \
> > > something wrong as the unit tests should ALWAYS pass.
> > > Ralph
> > >
> > >
> > >
> > > On Apr 26, 2014, at 10:30 PM, Ralph Goers <ralph.goers@dslextreme.com> wrote:
> > >
> > > > The error in CustomConfigurationTest is now fixed. On to FileOutputTest.
> > > >
> > > > Ralph
> > > >
> > > > On Apr 26, 2014, at 10:23 PM, Ralph Goers <ralph.goers@dslextreme.com> wrote:
> > > >
> > > > > I finally got a chance to look at CustomConfigurationTest. As I suspected \
> > > > > the unit test is incorrect.
> > > > > A check was added to see if the StatusLogger’s level was changed to info. \
> > > > > However, setting status=“info” doesn’t change the level of the Logger \
> > > > > attached to the status logger. It changes the Level associated with the \
> > > > > ConsoleListener added by the configuration. So this error has nothing to \
> > > > > do with LOG4J2-607.
> > > > > I should have a fix committed in a little bit.
> > > > >
> > > > > Ralph
> > > > >
> > > > > On Apr 21, 2014, at 12:03 AM, Matt Sicker <boards@gmail.com> wrote:
> > > > >
> > > > > > The first unit test failure there is due to LOG4J2-607. The second: not \
> > > > > > sure.
> > > > > >
> > > > > > On 21 April 2014 00:05, Ralph Goers <ralph.goers@dslextreme.com> wrote:
> > > > > > I just did a fresh checkout and am getting the following test failures:
> > > > > >
> > > > > >
> > > > > > Results :
> > > > > >
> > > > > > Failed tests:
> > > > > > CustomConfigurationTest.testConfig:61 expected same:<ERROR> was \
> > > > > > not:<INFO> FileOutputTest.testConfig:44 File is empty
> > > > > >
> > > > > > Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matt Sicker <boards@gmail.com>
> > > > >
> > > >
> > >
> >
> >
> >
> >
> > --
> > Matt Sicker <boards@gmail.com>
> >
> >
> >
> > --
> > Matt Sicker <boards@gmail.com>
>
>
>
>
> --
> Matt Sicker <boards@gmail.com>
>
>
>
> --
> Matt Sicker <boards@gmail.com>
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html \
charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space;"><div>I thought they all did - or it \
used to be in the parent pom.</div><div><br></div><div>Ralph</div><br><div><div>On \
Apr 27, 2014, at 12:57 PM, Matt Sicker <<a \
href="mailto:boards@gmail.com">boards@gmail.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Done. Looks \
like any jar-type project needs to include the maven-bundle-plugin in their build \
section.<div><br></div><div><div> <plugin></div><div> \
<groupId>org.apache.felix</groupId></div> \
<div> \
<artifactId>maven-bundle-plugin</artifactId></div><div> \
</plugin></div></div><div><br></div></div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On 27 April 2014 14:55, Matt \
Sicker <span dir="ltr"><<a href="mailto:boards@gmail.com" \
target="_blank">boards@gmail.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">On it.</div><div class="gmail_extra"><div><div \
class="h5"><br><br><div class="gmail_quote">On 27 April 2014 14:48, Ralph Goers <span \
dir="ltr"><<a href="mailto:ralph.goers@dslextreme.com" \
target="_blank">ralph.goers@dslextreme.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div style="word-wrap:break-word"><div>OK, but now the Flume \
samples are failing with the same error. Do you think you could run the full \
build and get it to work?</div>
<span><font color="#888888"><div><br></div><div>Ralph</div></font></span><div><br><div><div>On \
Apr 27, 2014, at 12:40 PM, Matt Sicker <<a href="mailto:boards@gmail.com" \
target="_blank">boards@gmail.com</a>> wrote:</div>
<br><blockquote type="cite"><div dir="ltr">Fixed it.</div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On 27 April 2014 14:38, Matt \
Sicker <span dir="ltr"><<a href="mailto:boards@gmail.com" \
target="_blank">boards@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">Now that's a weird one. I'll figure that out \
right after I finish running the log4j-core unit tests before a new commit.</div>
<div class="gmail_extra"><div><br><br><div class="gmail_quote">On 27 April 2014 \
14:30, Ralph Goers <span dir="ltr"><<a href="mailto:ralph.goers@dslextreme.com" \
target="_blank">ralph.goers@dslextreme.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div \
style="word-wrap:break-word"><div><sigh></div><div><br></div><div>Now the build \
is failing in the taglib project due to a missing MANIFEST.MF, which I find unusual \
because the jar plugin normally creates that.</div>
<span><font color="#888888"><div><br></div><div>Ralph</div></font></span><div><br><div><div>On \
Apr 26, 2014, at 10:51 PM, Ralph Goers <<a \
href="mailto:ralph.goers@dslextreme.com" \
target="_blank">ralph.goers@dslextreme.com</a>> wrote:</div>
<br><blockquote type="cite"><div style="word-wrap:break-word"><div>FileOutputTest was \
failing because the status level was changed to OFF and the test is expecting status \
logs to be written to a file. I’m not sure how why this commit was ever done \
since a “mvn clean install” would have failed. Let me reiterate one more time. \
If the unit tests fail don’t commit - you did something wrong as the unit tests \
should ALWAYS pass.</div>
<div><br></div><div>Ralph</div><div><br></div><div><br></div><br><div><div>On Apr 26, \
2014, at 10:30 PM, Ralph Goers <<a href="mailto:ralph.goers@dslextreme.com" \
target="_blank">ralph.goers@dslextreme.com</a>> wrote:</div>
<br><blockquote type="cite"><div style="word-wrap:break-word"><div>The error in \
CustomConfigurationTest is now fixed. On to \
FileOutputTest.</div><div><br></div><div>Ralph</div><br><div><div>On Apr 26, 2014, at \
10:23 PM, Ralph Goers <<a href="mailto:ralph.goers@dslextreme.com" \
target="_blank">ralph.goers@dslextreme.com</a>> wrote:</div>
<br><blockquote type="cite"><div style="word-wrap:break-word"><div>I finally got a \
chance to look at CustomConfigurationTest. As I suspected the unit test is \
incorrect. </div><div><br></div><div>A check was added to see if the \
StatusLogger’s level was changed to info. However, setting status=“info” \
doesn’t change the level of the Logger attached to the status logger. It changes the \
Level associated with the ConsoleListener added by the configuration. So this \
error has nothing to do with LOG4J2-607.</div>
<div><br></div><div>I should have a fix committed in a little \
bit.</div><div><br></div><div>Ralph</div><br><div><div>On Apr 21, 2014, at 12:03 AM, \
Matt Sicker <<a href="mailto:boards@gmail.com" \
target="_blank">boards@gmail.com</a>> wrote:</div>
<br><blockquote type="cite"><div dir="ltr">The first unit test failure there is due \
to LOG4J2-607. The second: not sure.</div><div class="gmail_extra"><br><br><div \
class="gmail_quote">On 21 April 2014 00:05, Ralph Goers <span dir="ltr"><<a \
href="mailto:ralph.goers@dslextreme.com" \
target="_blank">ralph.goers@dslextreme.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div style="word-wrap:break-word">I just did a fresh checkout \
and am getting the following test failures:<div><br></div>
<div><div style="margin:0px;font-size:10px;font-family:Monaco;min-height:14px"><br></div><div \
style="margin:0px;font-size:10px;font-family:Monaco">Results :</div><div \
style="margin:0px;font-size:10px;font-family:Monaco;min-height:14px">
<br></div><div style="margin:0px;font-size:10px;font-family:Monaco">Failed \
tests: </div><div style="margin:0px;font-size:10px;font-family:Monaco"> \
CustomConfigurationTest.testConfig:61 expected same:<ERROR> was \
not:<INFO></div>
<div style="margin:0px;font-size:10px;font-family:Monaco"> \
FileOutputTest.testConfig:44 File is empty</div><div \
style="margin:0px;font-size:10px;font-family:Monaco;min-height:14px"><br></div><div \
style="margin:0px;font-size:10px;font-family:Monaco">
Tests run: 543, Failures: 2, Errors: 0, Skipped: \
15</div></div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matt \
Sicker <<a href="mailto:boards@gmail.com" target="_blank">boards@gmail.com</a>> \
</div> </blockquote></div><br></div></blockquote></div><br></div></blockquote></div><br></div></blockquote></div><br></div></div></blockquote></div><br><br \
clear="all"><div><br></div></div><span><font color="#888888">-- <br>
Matt Sicker <<a href="mailto:boards@gmail.com" \
target="_blank">boards@gmail.com</a>> </font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Matt Sicker <<a \
href="mailto:boards@gmail.com" target="_blank">boards@gmail.com</a>> </div>
</blockquote></div><br></div></div></blockquote></div><br><br \
clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- \
<br>Matt Sicker <<a href="mailto:boards@gmail.com" \
target="_blank">boards@gmail.com</a>> </font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Matt Sicker <<a \
href="mailto:boards@gmail.com" target="_blank">boards@gmail.com</a>> </div>
</blockquote></div><br></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic