[prev in list] [next in list] [prev in thread] [next in thread]
List: log4j-dev
Subject: Re: unit test failures?
From: Matt Sicker <boards () gmail ! com>
Date: 2014-03-31 20:10:32
Message-ID: CACmp6krfXRKqkWZBivtOCDjgM6PCSFy_RVTRFtTaAn=8vU4RtA () mail ! gmail ! com
[Download RAW message or body]
In log4j-core/src/test/java/org/apache/logging/log4j/junit/CleanFiles.java
on line 48, could you try deleting the "assertTrue" part?
I get occasional test failures myself from the same test in my TeamCity
instance, but it seems to be a different issue with the log file *not*
being deleted! It's actually possible that this modified test has exposed a
potential bug with the FileAppender code. It seems to be holding on to the
file longer than it should.
On 31 March 2014 13:54, Ralph Goers <ralph.goers@dslextreme.com> wrote:
> I'd guess it is Windows specific. I haven't looked at what Matt did to
> this yet.
>
> Ralph
>
>
>
> On Mar 31, 2014, at 11:08 AM, Gary Gregory <garydgregory@gmail.com> wrote:
>
> I just tested a clean trunk and I get the following failures:
>
> Failed tests:
> ConfigurationTest.testLogToFile[0] Could not delete target\test.log,
> last modifed 3/31/14 1:50 PM
> ConfigurationTest.testConfiguredAppenders[0] Could not delete
> target\test.log, last modifed 3/31/14 1:51 PM
> ConfigurationTest.testLogger[0] Could not delete target\test.log, last
> modifed 3/31/14 1:51 PM
> ConfigurationTest.testLogToFile[1] Could not delete target\test.log,
> last modifed 3/31/14 1:51 PM
> ConfigurationTest.testConfiguredAppenders[1] Could not delete
> target\test.log, last modifed 3/31/14 1:51 PM
> ConfigurationTest.testLogger[1] Could not delete target\test.log, last
> modifed 3/31/14 1:51 PM
> ConfigurationTest.testLogToFile[2] Could not delete target\test.log,
> last modifed 3/31/14 1:51 PM
> ConfigurationTest.testConfiguredAppenders[2] Could not delete
> target\test.log, last modifed 3/31/14 1:51 PM
> ConfigurationTest.testLogger[2] Could not delete target\test.log, last
> modifed 3/31/14 1:51 PM
> FileOutputTest.testConfig:59 Couldn't delete file target\status.log
>
> Tests run: 542, Failures: 10, Errors: 0, Skipped: 15
>
> I tested with:
>
> Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19
> 08:51:28-0500)
> Maven home: C:\Java\apache-maven-3.0.5\bin\..
> Java version: 1.6.0_45, vendor: Sun Microsystems Inc.
> Java home: C:\Program Files\Java\jdk1.6.0_45\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>
> and:
>
> Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19
> 08:51:28-0500)
> Maven home: C:\Java\apache-maven-3.0.5\bin\..
> Java version: 1.8.0_20-ea, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\*jdk1.8.0_20*\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
>
> Matt? Bueller? Anybody?
>
> Gary
>
>
> On Mon, Mar 31, 2014 at 2:48 AM, Ralph Goers <ralph.goers@dslextreme.com>wrote:
>
> > Trunk is building for me.
> >
> > Ralph
> >
> > On Mar 30, 2014, at 7:43 PM, Gary Gregory <garydgregory@gmail.com> wrote:
> >
> > Hi All:
> >
> > I have a large change set (can't break it up into smaller bits) on my
> > machine and it does not seem related to the following failures I see:
> >
> > Results :
> >
> > Failed tests:
> > XmlFileAppenderTest.testFlushAtEndOfBatch:70 line1 incorrect: [ <Event
> > logger="com.foo.Bar" timestamp="1396233402662" level="INFO" thread="main"
> > fcqn="org.apache.logging.log4j.spi.AbstractLoggerProvider">], does not
> > contain: [<log4j:Even
> > t ]
> > ConfigurationTest.testLogToFile[0] null
> > ConfigurationTest.testConfiguredAppenders[0] null
> > ConfigurationTest.testLogger[0] null
> > ConfigurationTest.testLogToFile[1] null
> > ConfigurationTest.testConfiguredAppenders[1] null
> > ConfigurationTest.testLogger[1] null
> > ConfigurationTest.testLogToFile[2] null
> > ConfigurationTest.testConfiguredAppenders[2] null
> > ConfigurationTest.testLogger[2] null
> > FileOutputTest.testConfig:59 Couldn't delete file
> >
> > Tests in error:
> > JpaH2AppenderTest>AbstractJpaAppenderTest.testBaseJpaEntityAppender:107
> > » AppenderLogging
> >
> > JpaH2AppenderTest>AbstractJpaAppenderTest.testPerformanceOfAppenderWith10000EventsUsingBasicEntity:224
> > » AppenderLogging
> >
> > JpaH2AppenderTest>AbstractJpaAppenderTest.testBasicJpaEntityAppender:169 »
> > AppenderLogging
> >
> > JpaHyperSqlAppenderTest>AbstractJpaAppenderTest.testBaseJpaEntityAppender:107
> > » AppenderLogging
> >
> > JpaHyperSqlAppenderTest>AbstractJpaAppenderTest.testPerformanceOfAppenderWith10000EventsUsingBasicEntity:224
> > » AppenderLogging
> >
> > JpaHyperSqlAppenderTest>AbstractJpaAppenderTest.testBasicJpaEntityAppender:169
> > » AppenderLogging
> >
> > Tests run: 569, Failures: 11, Errors: 6, Skipped: 21
> >
> > Can folks comment on whether they can do a clean build?
> >
> > Thank you!
> >
> > Gary
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
> >
> >
> >
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
--
Matt Sicker <boards@gmail.com>
[Attachment #3 (text/html)]
<div dir="ltr">In log4j-core/src/test/java/org/apache/logging/log4j/junit/CleanFiles.java \
on line 48, could you try deleting the "assertTrue" \
part?<div><br></div><div>I get occasional test failures myself from the same test in \
my TeamCity instance, but it seems to be a different issue with the log file *not* \
being deleted! It's actually possible that this modified test has exposed a \
potential bug with the FileAppender code. It seems to be holding on to the file \
longer than it should.</div> </div><div class="gmail_extra"><br><br><div \
class="gmail_quote">On 31 March 2014 13:54, Ralph Goers <span dir="ltr"><<a \
href="mailto:ralph.goers@dslextreme.com" \
target="_blank">ralph.goers@dslextreme.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div style="word-wrap:break-word">I'd guess it is Windows \
specific. I haven't looked at what Matt did to this yet.<span class="HOEnZb"><font \
color="#888888"><div> <br></div></font></span><div><span class="HOEnZb"><font \
color="#888888">Ralph</font></span><div><div \
class="h5"><br><div><br></div><div><br><div><div>On Mar 31, 2014, at 11:08 AM, Gary \
Gregory <<a href="mailto:garydgregory@gmail.com" \
target="_blank">garydgregory@gmail.com</a>> wrote:</div> <br><blockquote \
type="cite"><div dir="ltr"><div>I just tested a clean trunk and I get the following \
failures:<br><br>Failed tests:<br> ConfigurationTest.testLogToFile[0] Could not \
delete target\test.log, last modifed 3/31/14 1:50 PM<br> \
ConfigurationTest.testConfiguredAppenders[0] Could not delete target\test.log, last \
modifed 3/31/14 1:51 PM<br> ConfigurationTest.testLogger[0] Could not delete \
target\test.log, last modifed 3/31/14 1:51 PM<br> \
ConfigurationTest.testLogToFile[1] Could not delete target\test.log, last modifed \
3/31/14 1:51 PM<br> ConfigurationTest.testConfiguredAppenders[1] Could not delete \
target\test.log, last modifed 3/31/14 1:51 PM<br>
ConfigurationTest.testLogger[1] Could not delete target\test.log, last modifed \
3/31/14 1:51 PM<br> ConfigurationTest.testLogToFile[2] Could not delete \
target\test.log, last modifed 3/31/14 1:51 PM<br> \
ConfigurationTest.testConfiguredAppenders[2] Could not delete target\test.log, last \
modifed 3/31/14 1:51 PM<br>
ConfigurationTest.testLogger[2] Could not delete target\test.log, last modifed \
3/31/14 1:51 PM<br> FileOutputTest.testConfig:59 Couldn't delete file \
target\status.log<br><br>Tests run: 542, Failures: 10, Errors: 0, Skipped: 15<br>
<br>I tested with:<br><br>Apache Maven 3.0.5 \
(r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 08:51:28-0500)<br>Maven home: \
C:\Java\apache-maven-3.0.5\bin\..<br>Java version: 1.6.0_45, vendor: Sun Microsystems \
Inc.<br>
Java home: C:\Program Files\Java\jdk1.6.0_45\jre<br>Default locale: en_US, platform \
encoding: Cp1252<br>OS name: "windows 7", version: "6.1", arch: \
"amd64", family: "windows"<br><br>
</div><div>and:<br></div><div><br>Apache Maven 3.0.5 \
(r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 08:51:28-0500)<br>Maven home: \
C:\Java\apache-maven-3.0.5\bin\..<br>Java version: 1.8.0_20-ea, vendor: Oracle \
Corporation<br>
Java home: C:\Program Files\Java\<b>jdk1.8.0_20</b>\jre<br>Default locale: en_US, \
platform encoding: Cp1252<br>OS name: "windows 7", version: \
"6.1", arch: "amd64", family: "dos"<br>
<br></div><div>Matt? Bueller? Anybody?<br><br></div>Gary<br></div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Mar 31, 2014 at 2:48 AM, \
Ralph Goers <span dir="ltr"><<a href="mailto:ralph.goers@dslextreme.com" \
target="_blank">ralph.goers@dslextreme.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div style="word-wrap:break-word">Trunk is building for \
me.<span><font color="#888888"><div><br></div><div> \
Ralph</div></font></span><div><div><br><div><div>On Mar 30, 2014, at 7:43 PM, Gary \
Gregory <<a href="mailto:garydgregory@gmail.com" \
target="_blank">garydgregory@gmail.com</a>> wrote:</div><br><blockquote \
type="cite">
<div dir="ltr"><div><div><div><div>Hi All:<br><br></div>I have a large change set \
(can't break it up into smaller bits) on my machine and it does not seem related \
to the following failures I see:<br><br>Results :<br> <br>
Failed tests:<br> XmlFileAppenderTest.testFlushAtEndOfBatch:70 line1 incorrect: [ \
<Event logger="com.foo.Bar" timestamp="1396233402662" \
level="INFO" thread="main" \
fcqn="org.apache.logging.log4j.spi.AbstractLoggerProvider">], does not \
contain: [<log4j:Even<br>
t ]<br> ConfigurationTest.testLogToFile[0] null<br> \
ConfigurationTest.testConfiguredAppenders[0] null<br> \
ConfigurationTest.testLogger[0] null<br> ConfigurationTest.testLogToFile[1] \
null<br> ConfigurationTest.testConfiguredAppenders[1] null<br>
ConfigurationTest.testLogger[1] null<br> ConfigurationTest.testLogToFile[2] \
null<br> ConfigurationTest.testConfiguredAppenders[2] null<br> \
ConfigurationTest.testLogger[2] null<br> FileOutputTest.testConfig:59 Couldn't \
delete file<br>
<br>Tests in error:<br> \
JpaH2AppenderTest>AbstractJpaAppenderTest.testBaseJpaEntityAppender:107 » \
AppenderLogging<br> \
JpaH2AppenderTest>AbstractJpaAppenderTest.testPerformanceOfAppenderWith10000EventsUsingBasicEntity:224 \
» AppenderLogging<br>
JpaH2AppenderTest>AbstractJpaAppenderTest.testBasicJpaEntityAppender:169 » \
AppenderLogging<br> \
JpaHyperSqlAppenderTest>AbstractJpaAppenderTest.testBaseJpaEntityAppender:107 » \
AppenderLogging<br> \
JpaHyperSqlAppenderTest>AbstractJpaAppenderTest.testPerformanceOfAppenderWith10000EventsUsingBasicEntity:224 \
» AppenderLogging<br>
JpaHyperSqlAppenderTest>AbstractJpaAppenderTest.testBasicJpaEntityAppender:169 \
» AppenderLogging<br><br>Tests run: 569, Failures: 11, Errors: 6, Skipped: \
21<br><br></div>Can folks comment on whether they can do a clean build?<br>
<br></div>Thank you!<br><br></div>Gary<br clear="all"><div><br>-- <br><div \
dir="ltr">E-Mail: <a href="mailto:garydgregory@gmail.com" \
target="_blank">garydgregory@gmail.com</a> | <a href="mailto:ggregory@apache.org" \
target="_blank">ggregory@apache.org </a><br>
<a href="http://www.manning.com/bauer3/" target="_blank">Java Persistence with \
Hibernate, Second Edition</a><br><a href="http://www.manning.com/tahchiev/" \
target="_blank">JUnit in Action, Second Edition</a><br><a \
href="http://www.manning.com/templier/" target="_blank">Spring Batch in \
Action</a><br>
Blog: <a href="http://garygregory.wordpress.com/" \
target="_blank">http://garygregory.wordpress.com</a> <br>Home: <a \
href="http://garygregory.com/" target="_blank">http://garygregory.com/</a><br>Tweet! \
<a href="http://twitter.com/GaryGregory" \
target="_blank">http://twitter.com/GaryGregory</a></div>
</div></div>
</blockquote></div><br></div></div></div></blockquote></div><br><br \
clear="all"><br>-- <br><div dir="ltr">E-Mail: <a href="mailto:garydgregory@gmail.com" \
target="_blank">garydgregory@gmail.com</a> | <a href="mailto:ggregory@apache.org" \
target="_blank">ggregory@apache.org </a><br>
<a href="http://www.manning.com/bauer3/" target="_blank">Java Persistence with \
Hibernate, Second Edition</a><br><a href="http://www.manning.com/tahchiev/" \
target="_blank">JUnit in Action, Second Edition</a><br><a \
href="http://www.manning.com/templier/" target="_blank">Spring Batch in \
Action</a><br>
Blog: <a href="http://garygregory.wordpress.com/" \
target="_blank">http://garygregory.wordpress.com</a> <br>Home: <a \
href="http://garygregory.com/" target="_blank">http://garygregory.com/</a><br>Tweet! \
<a href="http://twitter.com/GaryGregory" \
target="_blank">http://twitter.com/GaryGregory</a></div>
</div>
</blockquote></div><br></div></div></div></div></div></blockquote></div><br><br \
clear="all"><div><br></div>-- <br>Matt Sicker <<a href="mailto:boards@gmail.com" \
target="_blank">boards@gmail.com</a>> </div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic