[prev in list] [next in list] [prev in thread] [next in thread] 

List:       log4j-dev
Subject:    [jira] [Reopened] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging
From:       "Nick Williams (JIRA)" <jira () apache ! org>
Date:       2014-01-30 4:08:11
Message-ID: JIRA.12660290.1375029997964.8149.1391054891079 () arcas
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

Nick Williams reopened LOG4J2-323:
----------------------------------


Remko,

Nulling out the reference to the {{ThreadLocal}} is not enough (in fact, it's not \
even necessary). If it were enough, then once the object holding the reference was \
eligible for garbage collection the {{ThreadLocal}} would go away—but it doesn't.

To remove a {{ThreadLocal}}'s contents, you must call the {{remove}} method on the \
{{ThreadLocal}}. There is no reason to null out the {{ThreadLocal}} instance once \
{{remove}} has been called.

I'll have this fixed shortly.

> ThreadLocal-leak on tomcat shutdown when using async logging
> ------------------------------------------------------------
> 
> Key: LOG4J2-323
> URL: https://issues.apache.org/jira/browse/LOG4J2-323
> Project: Log4j 2
> Issue Type: Bug
> Affects Versions: 2.0-beta9
> Environment: Mac OS X 10.8.4, Tomcat 7.0.42, java version 1.6.0_51
> Reporter: Michael Kloster
> Assignee: Remko Popma
> Priority: Minor
> Fix For: 2.0-rc1
> 
> 
> When shutting down Tomcat 7.0.42, catalina.out displays the following warning \
> indicating a memory leak: {code}
> Jul 28, 2013 9:55:59 AM org.apache.coyote.AbstractProtocol start
> INFO: Starting ProtocolHandler ["http-bio-8080"]
> Jul 28, 2013 9:55:59 AM org.apache.coyote.AbstractProtocol start
> INFO: Starting ProtocolHandler ["ajp-bio-8009"]
> Jul 28, 2013 9:55:59 AM org.apache.catalina.startup.Catalina start
> INFO: Server startup in 841 ms
> Jul 28, 2013 9:56:09 AM org.apache.catalina.core.StandardServer await
> INFO: A valid shutdown command was received via the shutdown port. Stopping the \
> Server instance. Jul 28, 2013 9:56:09 AM org.apache.coyote.AbstractProtocol pause
> INFO: Pausing ProtocolHandler ["http-bio-8080"]
> Jul 28, 2013 9:56:09 AM org.apache.coyote.AbstractProtocol pause
> INFO: Pausing ProtocolHandler ["ajp-bio-8009"]
> Jul 28, 2013 9:56:09 AM org.apache.catalina.core.StandardService stopInternal
> INFO: Stopping service Catalina
> Jul 28, 2013 9:56:09 AM org.apache.catalina.loader.WebappClassLoader \
>                 checkThreadLocalMapForLeaks
> SEVERE: The web application [/asynclog] created a ThreadLocal with key of type \
> [java.lang.ThreadLocal] (value [java.lang.ThreadLocal@648bfdea]) and a value of \
> type [org.apache.logging.log4j.core.async.AsyncLogger.Info] (value \
> [org.apache.logging.log4j.core.async.AsyncLogger$Info@4e26d560]) but failed to \
> remove it when the web application was stopped. Threads are going to be renewed \
> over time to try and avoid a probable memory leak. Jul 28, 2013 9:56:09 AM \
>                 org.apache.coyote.AbstractProtocol stop
> INFO: Stopping ProtocolHandler ["http-bio-8080"]
> Jul 28, 2013 9:56:09 AM org.apache.coyote.AbstractProtocol stop
> INFO: Stopping ProtocolHandler ["ajp-bio-8009"]
> Jul 28, 2013 9:56:09 AM org.apache.coyote.AbstractProtocol destroy
> INFO: Destroying ProtocolHandler ["http-bio-8080"]
> Jul 28, 2013 9:56:09 AM org.apache.coyote.AbstractProtocol destroy
> INFO: Destroying ProtocolHandler ["ajp-bio-8009"]
> {code}
> {code:xml|title=log4j2.xml|borderStyle=solid}
> <?xml version="1.0" encoding="UTF-8"?>
> <configuration status="WARN">
> <appenders>
> <FastRollingFile name="MyFileLog" filename="logs/my.log"
> filePattern="logs/my-%d{COMPACT}.log">
> <PatternLayout pattern="%d %p %c{1.} [%t] %m%n" />
> 	<Policies>
> 	  <SizeBasedTriggeringPolicy size="5MB" />
> 	</Policies>
> </FastRollingFile>
> <Console name="Console" target="SYSTEM_OUT">
> <PatternLayout pattern="%d %p %c{1.} [%t] %m%n" />
> </Console>
> </appenders>
> <loggers>
> <logger name="mylogger" level="INFO" additivity="false">
> <appender-ref ref="MyFileLog" />
> </logger>
> <root level="TRACE">
> <appender-ref ref="Console" />
> </root>
> </loggers>
> </configuration>
> {code}
> {code:title=log4j2.xml|borderStyle=solid}
> #!/bin/bash
> CATALINA_OPTS=-DLog4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector
>  {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]