[prev in list] [next in list] [prev in thread] [next in thread]
List: log4j-dev
Subject: Re: SMTPAppender work in progress, questions
From: Scott Severtson <ssevertson () digitalmeasures ! com>
Date: 2012-12-21 19:37:30
Message-ID: 50D4BA7A.6020007 () digitalmeasures ! com
[Download RAW message or body]
OK. I've attached SMTPAppender as a patch to LOG4J2-131
<https://issues.apache.org/jira/browse/LOG4J2-131>, and created
LOG4J2-136 <https://issues.apache.org/jira/browse/LOG4J2-136> for the
Syslog newline patch. Please let me know if there's any improvements
that could be made to either.
FYI, I'll be out of the office after today until the end of the year.
So, if there's anything that would block inclusion of either patch in
the new beta 4 release, I'd appreciate knowing ASAP!
Thanks,
--Scott Severtson
On 12/21/2012 02:13 PM, Ralph Goers wrote:
> Please create a Jira issue and attach the patches or files to that.
>
> Please create a separate Jira for the Syslog layout fix/enhancement.
>
> Ralph
>
> On Dec 21, 2012, at 9:31 AM, Scott Severtson wrote:
>
> > On 12/21/2012 02:08 AM, Ralph Goers wrote:
> > > On Dec 20, 2012, at 5:02 PM, Scott Severtson wrote:
> > > > I'll see what I can wrap up in the short term, for possible inclusion in beta \
> > > > 4.
> > > Sounds great!
> > Code is complete, uses a manager for SMTP Session instances. It has decent unit \
> > test coverage, including using Dumbster. I'll be deploying it to our Alpha \
> > environment this afternoon for a bit more real-world testing.
> > How do you folks prefer to receive contributions? Unified diffs to the dev \
> > mailing list, or JIRA issues with attachments?
> > I've also got a minor patch to contribute to the SyslogAppender/Layouts, which \
> > allows optional escaping of newline characters in the message body (so the \
> > RFC-3164/5424 framing doesn't get screwed up).
> > --Scott
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> > For additional commands, e-mail: log4j-dev-help@logging.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
OK. I've attached SMTPAppender as a patch to <a id="key-val"
rel="12618918"
href="https://issues.apache.org/jira/browse/LOG4J2-131">LOG4J2-131</a>,
and created <a id="key-val" rel="12625041"
href="https://issues.apache.org/jira/browse/LOG4J2-136">LOG4J2-136</a>
for the Syslog newline patch. Please let me know if there's any
improvements that could be made to either.<br>
<br>
FYI, I'll be out of the office after today until the end of the
year. So, if there's anything that would block inclusion of either
patch in the new beta 4 release, I'd appreciate knowing ASAP!<br>
<br>
Thanks,<br>
--Scott Severtson<br>
<br>
<br>
<div class="moz-cite-prefix">On 12/21/2012 02:13 PM, Ralph Goers
wrote:<br>
</div>
<blockquote
cite="mid:FFF88B3F-8EC7-40C0-945C-7FE6C01FF211@dslextreme.com"
type="cite">
<pre wrap="">Please create a Jira issue and attach the patches or files to \
that.
Please create a separate Jira for the Syslog layout fix/enhancement.
Ralph
On Dec 21, 2012, at 9:31 AM, Scott Severtson wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 12/21/2012 02:08 AM, Ralph Goers wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Dec 20, 2012, at 5:02 PM, Scott Severtson wrote:
</pre>
<blockquote type="cite">
<pre wrap="">I'll see what I can wrap up in the short term, for possible \
inclusion in beta 4. </pre>
</blockquote>
<pre wrap="">Sounds great!
</pre>
</blockquote>
<pre wrap="">
Code is complete, uses a manager for SMTP Session instances. It has decent unit test \
coverage, including using Dumbster. I'll be deploying it to our Alpha environment \
this afternoon for a bit more real-world testing.
How do you folks prefer to receive contributions? Unified diffs to the dev mailing \
list, or JIRA issues with attachments?
I've also got a minor patch to contribute to the SyslogAppender/Layouts, which allows \
optional escaping of newline characters in the message body (so the RFC-3164/5424 \
framing doesn't get screwed up).
--Scott
---------------------------------------------------------------------
To unsubscribe, e-mail: <a class="moz-txt-link-abbreviated" \
href="mailto:log4j-dev-unsubscribe@logging.apache.org">log4j-dev-unsubscribe@logging.apache.org</a>
For additional commands, e-mail: <a class="moz-txt-link-abbreviated" \
href="mailto:log4j-dev-help@logging.apache.org">log4j-dev-help@logging.apache.org</a>
</pre>
</blockquote>
<pre wrap="">
---------------------------------------------------------------------
To unsubscribe, e-mail: <a class="moz-txt-link-abbreviated" \
href="mailto:log4j-dev-unsubscribe@logging.apache.org">log4j-dev-unsubscribe@logging.apache.org</a>
For additional commands, e-mail: <a class="moz-txt-link-abbreviated" \
href="mailto:log4j-dev-help@logging.apache.org">log4j-dev-help@logging.apache.org</a>
</pre>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic