[prev in list] [next in list] [prev in thread] [next in thread] 

List:       log4j-dev
Subject:    DO NOT REPLY [Bug 52699] New: Misleading DailyRollingFileAppender javadoc
From:       bugzilla () apache ! org
Date:       2012-02-17 17:13:46
Message-ID: bug-52699-31091 () https ! issues ! apache ! org/bugzilla/
[Download RAW message or body]

https://issues.apache.org/bugzilla/show_bug.cgi?id=52699

             Bug #: 52699
           Summary: Misleading DailyRollingFileAppender javadoc
           Product: Log4j
           Version: 1.2
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Appender
        AssignedTo: log4j-dev@logging.apache.org
        ReportedBy: parsons.nate@gmail.com
    Classification: Unclassified


It seems like the javadoc for this class was written by someone that thinks
midnight happens at the end of the day. Ex:

> At midnight, on March 8th, 2002, /foo/bar.log will be copied to \
> /foo/bar.log.2002-03-08. Logging for the 9th day of March will be output to \
> /foo/bar.log until it is rolled over the next day. 

But at 00:00:00 8/3/12, no logging events for 8/3 have been generated, and
logging for the 9th day of March doesn't even start until the next day (after
it has rolled over?)

So, if I understand the code correctly, this should instead read

> At midnight, on March 8th, 2002, /foo/bar.log will be copied to \
> /foo/bar.log.2002-03-07. Logging for the 8th day of March will be output to \
> /foo/bar.log until it is rolled over the next day. 


P.S. the comment on line 319 is also wrong, I think.
s/datedFilename/scheduledFilename/

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]