[prev in list] [next in list] [prev in thread] [next in thread] 

List:       log4j-dev
Subject:    DO NOT REPLY [Bug 45753] Code contribution: BurstFilter for extras
From:       bugzilla () apache ! org
Date:       2009-04-01 18:42:09
Message-ID: 20090401184209.51EAD234C045 () brutus ! apache ! org
[Download RAW message or body]

https://issues.apache.org/bugzilla/show_bug.cgi?id=45753





--- Comment #3 from Chad LaVigne <chad_lavigne@yahoo.com>  2009-04-01 11:42:05 PST ---
Is there any feedback on this contribution?

(In reply to comment #2)
> Created an attachment (id=23401)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23401) [details]
> Update to BurstFilter contribution
> 
> The attached code addresses the following issues mentioned by Curt.  
> 
> 1) License headers are fixed
> 2) @Author tags removed
> 3) JavaDoc comments added to all methods
> 4) Filter is now level aware
> 5) BurstFilter & TokenBucket have been condensed into one class
> 6) TokenBucket.getToken() now returns false if empty 
> 
> I didn't rename the filter because I actually submitted this code about 2 years
> ago under the name TokenBucketFilter and it was requested at that time that I
> rename it to something like BurstFilter so that it would be implementation
> agnostic.  Let me know what the consensus is, I can certainly rename it if need
> be.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org

[prev in list] [next in list] [prev in thread] [next in thread]