[prev in list] [next in list] [prev in thread] [next in thread] 

List:       log4j-dev
Subject:    DO NOT REPLY [Bug 33278] NPE thrown durring daily log file rollover
From:       bugzilla () apache ! org
Date:       2008-11-12 21:37:07
Message-ID: 20081112213707.BD153234C25F () brutus ! apache ! org
[Download RAW message or body]

https://issues.apache.org/bugzilla/show_bug.cgi?id=33278





--- Comment #6 from QualityChecker <qualitychecker@free.fr>  2008-11-12 13:37:06 PST ---
I would suggest to add at least a test this.qw!=null and this.layout!=null at
the beginning of subAppend of WriterAppender, like it is done in many other
methods, even if they are tested in checkEntryConditions()
May be log a special alarm in case this.qw==null or this.layout==null ??

In writeFooter and writeHeader I would suggest to replace layout by
this.layout, more readable.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org

[prev in list] [next in list] [prev in thread] [next in thread]