[prev in list] [next in list] [prev in thread] [next in thread]
List: log4j-dev
Subject: Re: MANIFEST.MF broken in log4j-1.2.15.jar
From: "Dominique Laurent" <lauredo () gmail ! com>
Date: 2008-02-06 18:35:33
Message-ID: 89706c0f0802061035y7f3da2adw6a62f5b005c78e3d () mail ! gmail ! com
[Download RAW message or body]
Hi Curt,
What you can use with dots is "Extension-Name" e.g.
Extension-Name: org.apache.log4j
but "Name" needs slashes and using "Name" with dots prevents
Package#getImplementationVersion() from returning something useful.
So you could have:
Extension-Name: org.apache.log4j
Name: org/apache/log4j/
and everyone would be happy I guess.
Kind regards,
Dominique
On 06/02/2008, Curt Arnold <carnold@apache.org> wrote:
>
>
> On Feb 6, 2008, at 9:32 AM, Dominique Laurent wrote:
>
> > Hi,
> >
> > Just to let you know that the manifest (MANIFEST.MF) in
> > log4j-1.2.15.jar uses:
> >
> >
> > Name: org.apache.log4j
> >
> > instead of
> >
> >
> > Name: org/apache/log4j/
> >
> >
> > Note the dot '.' instead of the slash '/'.
> >
> > It means that the following piece of code:
> >
> > String implementationVersion =
> > org
> > .apache.log4j.Appender.class.getPackage().getImplementationVersion();
> > System.out.println("implementationVersion: \"" +
> > implementationVersion + '"');
> >
> > now returns null instead of implementationVersion: "1.2.15" as it
> > did in previous releases.
> >
> > Could you please reset it to "Name: org/apache/log4j/" ?
> >
> > Thanks in advance,
> >
> > Best regards,
> > Dominique
>
>
> I've confirmed it is a change from log4j 1.2.14 and earlier. It may
> have been a mistake when writing the Maven POM file, but it may have
> been intentional and needs a bit more research to see if there was a
> motivation behind the change.
>
> From
> http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#Manifest%20Specification
> >
> > The individual sections define various attributes for packages or
> > files contained in this JAR file. Not all files in the JAR file need
> > to be listed in the manifest as entries, but all files which are to
> > be signed must be listed. The manifest file itself must not be
> > listed. Each section must start with an attribute with the name as
> > "Name", and the value must be a relative path to the file, or an
> > absolute URL referencing data outside the archive.
>
> So the name definitely should be separated with slashes.
>
> Could you file a bug report (http://issues.apache.org/bugzilla) for
> this issue and specify the JVM vendor and version you were using.
>
> Likely best to keep the "org.apache.log4j" entry and add a second
> entry for "org/apache/log4j".
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
[Attachment #3 (text/html)]
Hi Curt,<br><br>What you can use with dots is "Extension-Name" \
e.g.<br><br>Extension-Name: org.apache.log4j<br><br>but "Name" needs \
slashes and using "Name" with dots prevents \
Package#getImplementationVersion() from returning something useful.<br> <br>So you \
could have:<br><br>Extension-Name: org.apache.log4j<br>Name: \
org/apache/log4j/<br><br>and everyone would be happy I guess.<br><br>Kind \
regards,<br>Dominique<br><br><br><div><span class="gmail_quote">On 06/02/2008, <b \
class="gmail_sendername">Curt Arnold</b> <<a \
href="mailto:carnold@apache.org">carnold@apache.org</a>> wrote:</span><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> <br>On Feb 6, 2008, at 9:32 AM, Dominique Laurent \
wrote:<br><br>> Hi,<br>><br>> Just to let you know that the manifest \
(MANIFEST.MF) in<br>> log4j-1.2.15.jar uses:<br>><br>><br>> Name: \
org.apache.log4j<br> ><br>> instead of<br>><br>><br>> Name: \
org/apache/log4j/<br>><br>><br>> Note the dot '.' instead of the \
slash '/'.<br>><br>> It means that the following piece of \
code:<br>><br> > String \
implementationVersion =<br>> org<br>> \
.apache.log4j.Appender.class.getPackage().getImplementationVersion();<br>> \
System.out.println("implementationVersion: \"" +<br>> \
implementationVersion + '"');<br> ><br>> now returns null instead \
of implementationVersion: "1.2.15" as it<br>> did in previous \
releases.<br>><br>> Could you please reset it to "Name: \
org/apache/log4j/" ?<br>><br>> Thanks in advance,<br> ><br>> Best \
regards,<br>> Dominique<br><br><br>I've confirmed it is a change from log4j \
1.2.14 and earlier. It may<br>have been a mistake when writing the Maven \
POM file, but it may have<br>been intentional and needs a bit more research to see if \
there was a<br> motivation behind the change.<br><br> From <a \
href="http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#Manifest%20Specification" \
>http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#Manifest%20Specification</a><br>><br>
>
> The individual sections define various attributes for packages or<br>> files \
contained in this JAR file. Not all files in the JAR file need<br>> to be listed \
in the manifest as entries, but all files which are to<br> > be signed must be \
listed. The manifest file itself must not be<br>> listed. Each section \
must start with an attribute with the name as<br>> "Name", and the value \
must be a relative path to the file, or an<br> > absolute URL referencing data \
outside the archive.<br><br>So the name definitely should be separated with \
slashes.<br><br>Could you file a bug report (<a \
href="http://issues.apache.org/bugzilla">http://issues.apache.org/bugzilla</a>) \
for<br> this issue and specify the JVM vendor and version you were \
using.<br><br>Likely best to keep the "org.apache.log4j" entry and add a \
second<br>entry for "org/apache/log4j".<br><br><br>---------------------------------------------------------------------<br>
To unsubscribe, e-mail: <a \
href="mailto:log4j-dev-unsubscribe@logging.apache.org">log4j-dev-unsubscribe@logging.apache.org</a><br>For \
additional commands, e-mail: <a \
href="mailto:log4j-dev-help@logging.apache.org">log4j-dev-help@logging.apache.org</a><br>
<br></blockquote></div><br>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic