[prev in list] [next in list] [prev in thread] [next in thread] 

List:       log4cxx-dev
Subject:    Patch for rolling file appender
From:       Jeff Apple <japple () paradise ! net ! nz>
Date:       2004-09-28 9:32:58
Message-ID: 41592FCA.2000902 () paradise ! net ! nz
[Download RAW message or body]

When compiled using the Sun Forte compiler, the rolling file appender 
rolls the files on each message. tellp() has to be cast to long for the 
comparison to be valid. I haven't tried any other compilers. Patch below.

--- rollingfileappender.cpp     2004-09-14 21:43:13.000000000 +1200
+++ rollingfileappender.cpp     2004-09-14 21:43:07.000000000 +1200
@@ -102,7 +102,7 @@
void RollingFileAppender::subAppend(const spi::LoggingEventPtr& event)
{
       FileAppender::subAppend(event);
-       if(!fileName.empty() && ofs.tellp() >= maxFileSize)
+       if(!fileName.empty() && ((long)ofs.tellp()) >= maxFileSize)
       {
               rollOver();
       }

[prev in list] [next in list] [prev in thread] [next in thread]