[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lnst-developers
Subject:    [PATCH-next v2 02/18] lnst.Recipes.ENRT.BaseEnrtRecipe: refactor test method with contextmanagers
From:       olichtne () redhat ! com
Date:       2019-06-13 11:50:15
Message-ID: 20190613115031.27335-3-olichtne () redhat ! com
[Download RAW message or body]

From: Ondrej Lichtner <olichtne@redhat.com>

Using context managers via the contextmanager decorator method makes
this a little clearer and moves the individual try-finally blocks into
their own functions.

Signed-off-by: Ondrej Lichtner <olichtne@redhat.com>
---
 lnst/Recipes/ENRT/BaseEnrtRecipe.py | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/lnst/Recipes/ENRT/BaseEnrtRecipe.py b/lnst/Recipes/ENRT/BaseEnrtRecipe.py
index 18e4040..66f563d 100644
--- a/lnst/Recipes/ENRT/BaseEnrtRecipe.py
+++ b/lnst/Recipes/ENRT/BaseEnrtRecipe.py
@@ -1,4 +1,5 @@
 import re
+from contextlib import contextmanager
 
 from lnst.Common.LnstError import LnstError
 from lnst.Common.Parameters import Param, IntParam, StrParam, BoolParam, ListParam
@@ -102,13 +103,9 @@ class BaseEnrtRecipe(PingTestAndEvaluate, PerfRecipe):
     cpu_perf_tool = Param(default=StatCPUMeasurement)
 
     def test(self):
-        main_config = self.test_wide_configuration()
-
-        try:
+        with self._test_wide_context() as main_config:
             for sub_config in self.generate_sub_configurations(main_config):
-                self.apply_sub_configuration(main_config, sub_config)
-
-                try:
+                with self._sub_context(main_config, sub_config) as recipe_config:
                     for ping_config in self.generate_ping_configurations(main_config,
                                                                          sub_config):
                         result = self.ping_test(ping_config)
@@ -118,10 +115,14 @@ def test(self):
                                                                          sub_config):
                         result = self.perf_test(perf_config)
                         self.perf_report_and_evaluate(result)
-                finally:
-                    self.remove_sub_configuration(main_config, sub_config)
+
+    @contextmanager
+    def _test_wide_context(self):
+        config = self.test_wide_configuration()
+        try:
+            yield config
         finally:
-            self.test_wide_deconfiguration(main_config)
+            self.test_wide_deconfiguration(config)
 
     def test_wide_configuration(self):
         raise NotImplementedError("Method must be defined by a child class.")
@@ -129,6 +130,14 @@ def test_wide_configuration(self):
     def test_wide_deconfiguration(self, main_config):
         raise NotImplementedError("Method must be defined by a child class.")
 
+    @contextmanager
+    def _sub_context(self, main_config, sub_config):
+        self.apply_sub_configuration(main_config, sub_config)
+        try:
+            yield (main_config, sub_config)
+        finally:
+            self.remove_sub_configuration(main_config, sub_config)
+
     def generate_sub_configurations(self, main_config):
         for offload_settings in self.params.offload_combinations:
             sub_config = EnrtSubConfiguration()
-- 
2.22.0
_______________________________________________
LNST-developers mailing list -- lnst-developers@lists.fedorahosted.org
To unsubscribe send an email to lnst-developers-leave@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedorahosted.org/archives/list/lnst-developers@lists.fedorahosted.org

[prev in list] [next in list] [prev in thread] [next in thread]