[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lm-sensors
Subject:    Re: [lm-sensors] [PATCH] hwmon/applesmc: Fix uninitialized variables warnings
From:       Guenter Roeck <linux () roeck-us ! net>
Date:       2015-11-06 0:45:02
Message-ID: 20151106004502.GB32106 () roeck-us ! net
[Download RAW message or body]

On Thu, Nov 05, 2015 at 03:39:27PM -0700, Shuah Khan wrote:
> Fix the following "maybe used uninitialized" warnings by
> initializing the variables to keep the compiler quiet.
> There is no "used uninitialized" in this case.
> 
>   CC [M]  drivers/hwmon/applesmc.o
> drivers/hwmon/applesmc.c: In function ‘applesmc_init_smcreg':
> drivers/hwmon/applesmc.c:595:43: warning: ‘right_light_sensor'
> may be used uninitialized in this function [-Wmaybe-uninitialized]
>   s->num_light_sensors = left_light_sensor + right_light_sensor;
>                                            ^
> drivers/hwmon/applesmc.c:540:26: note: ‘right_light_sensor' was
> declared here
>   bool left_light_sensor, right_light_sensor;
>                           ^
> drivers/hwmon/applesmc.c:595:43: warning: ‘left_light_sensor' may
> be used uninitialized in this function [-Wmaybe-uninitialized]
>   s->num_light_sensors = left_light_sensor + right_light_sensor;
>                                            ^
> drivers/hwmon/applesmc.c:540:7: note: ‘left_light_sensor' was
> declared here
>   bool left_light_sensor, right_light_sensor;
>        ^
> 
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>

Applied.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
[prev in list] [next in list] [prev in thread] [next in thread]