[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lm-sensors
Subject:    Re: [lm-sensors] [PATCH 2/2] hwmon: (jc42) Fix integer overflow
From:       Jean Delvare <jdelvare () suse ! de>
Date:       2015-01-23 9:07:31
Message-ID: 20150123100731.653c0fe6 () endymion ! delvare
[Download RAW message or body]

Hi Guenter,

On Sun, 18 Jan 2015 17:36:48 -0800, Guenter Roeck wrote:
> Mixed use of long and int caused an integer overflow when writing large limits.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/hwmon/jc42.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
> index 262d808..f8e3bbb 100644
> --- a/drivers/hwmon/jc42.c
> +++ b/drivers/hwmon/jc42.c
> @@ -201,7 +201,7 @@ struct jc42_data {
>  #define JC42_TEMP_MIN		0
>  #define JC42_TEMP_MAX		125000
>  
> -static u16 jc42_temp_to_reg(int temp, bool extended)
> +static u16 jc42_temp_to_reg(long temp, bool extended)
>  {
>  	int ntemp = clamp_val(temp,
>  			      extended ? JC42_TEMP_MIN_EXTENDED :

Good catch.

Reviewed-by: Jean Delvare <jdelvare@suse.de>

-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
[prev in list] [next in list] [prev in thread] [next in thread]