[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-dev
Subject:    [LLVMdev] Shouldn't tools and projects in .gitignore go to .gitmodules?
From:       Kuba Ober <kuba () mareimbrium ! org>
Date:       2014-03-10 19:52:51
Message-ID: 734309C4-BD62-4E62-AA5E-4AAA994D6EC4 () mareimbrium ! org
[Download RAW message or body]

I think it is erroneous to have the subrepository projects and tools listed in .gitignore.

Instead of being ignored, methinks they should be listed as submodules in .gitmodules:

[submodule "tools/clang"]
        path = tools/clang
        url = ../clang.git
[submodule "projects/compiler-rt"]
        path = projects/compiler-rt
        url = ../compiler-rt.git
[submodule "projects/test-suite"]
        path = projects/test-suite
        url = ../test-suite.git
[submodule "tools/lldb"]
        path = tools/lldb
        url = ../lldb.git
[submodule "tools/lld"]
        path = tools/lld
        url = ../lld.git

I’ve attached a patch just in case this was the right way to go.

Cheers, Kuba Ober


["llvmgit.patch" (llvmgit.patch)]

--- a/.gitignore
+++ b/.gitignore
@@ -42,11 +42,7 @@ projects/*
 !projects/sample
 !projects/CMakeLists.txt
 !projects/Makefile
-# Clang, which is tracked independently.
-tools/clang
-# LLDB, which is tracked independently.
-tools/lldb
-# lld, which is tracked independently.
-tools/lld
+!projects/compiler-rt
+!projects/test-suite
 # Sphinx build tree, if building in-source dir.
 docs/_build
--- /dev/null	2014-03-10 15:50:41.000000000 -0400
+++ .gitmodules	2014-03-10 15:46:26.000000000 -0400
@@ -0,0 +1,15 @@
+[submodule "tools/clang"]
+	path = tools/clang
+	url = ../clang.git
+[submodule "projects/compiler-rt"]
+	path = projects/compiler-rt
+	url = ../compiler-rt.git
+[submodule "projects/test-suite"]
+	path = projects/test-suite
+	url = ../test-suite.git
+[submodule "tools/lldb"]
+	path = tools/lldb
+	url = ../lldb.git
+[submodule "tools/lld"]
+	path = tools/lld
+	url = ../lld.git


_______________________________________________
LLVM Developers mailing list
LLVMdev@cs.uiuc.edu         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev


[prev in list] [next in list] [prev in thread] [next in thread]