[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-dev
Subject:    Re: [LLVMdev] Purpose of -debug-compile in NVPTX backend
From:       Justin Holewinski <justin.holewinski () gmail ! com>
Date:       2012-11-30 2:17:38
Message-ID: CAJgxuafhjg=pcjysBaQ0gYf-hJDghdKzWqO9E0r=5u9ksNs3yQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Yes, this is a bit redundant.  It can be removed for now.


On Tue, Nov 27, 2012 at 5:04 PM, Kai <kai@redstar.de> wrote:

> Hi!
>
> My general understanding of the debug symbol support is that:
>
> - the backend defines in the XXXMCAsmInfo class if debug information is
> supported (e.g. SupportsDebugInformation = true / false)
> - if I don't want to output debug information then I can use the (hidden)
> command line option -disable-debug-info-print (defined in DwarfDebug.cpp).
>
> However, in NVPTXMCAsmInfo.cpp I found:
>
> - a new command line option:
>
> bool CompileForDebugging;
> static cl::opt<bool, true>
> Debug("debug-compile", cl::desc("Compile for debugging"), cl::Hidden,
>       cl::location(**CompileForDebugging),
>       cl::init(false));
>
> - and the assignment
>
>   SupportsDebugInformation = CompileForDebugging;
>
> Isn't this redundant code? If yes then the attached patch should be
> committed. If not then I like to know whats going on here....
>
> Regards
> Kai
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev@cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>


-- 

Thanks,

Justin Holewinski

[Attachment #5 (text/html)]

Yes, this is a bit redundant.  It can be removed for now.<div \
class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Nov 27, 2012 at 5:04 PM, \
Kai <span dir="ltr">&lt;<a href="mailto:kai@redstar.de" \
target="_blank">kai@redstar.de</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi!<br> <br>
My general understanding of the debug symbol support is that:<br>
<br>
- the backend defines in the XXXMCAsmInfo class if debug information is supported \
                (e.g. SupportsDebugInformation = true / false)<br>
- if I don&#39;t want to output debug information then I can use the (hidden) command \
line option -disable-debug-info-print (defined in DwarfDebug.cpp).<br> <br>
However, in NVPTXMCAsmInfo.cpp I found:<br>
<br>
- a new command line option:<br>
<br>
bool CompileForDebugging;<br>
static cl::opt&lt;bool, true&gt;<br>
Debug(&quot;debug-compile&quot;, cl::desc(&quot;Compile for debugging&quot;), \
cl::Hidden,<br>  cl::location(<u></u>CompileForDebugging),<br>
      cl::init(false));<br>
<br>
- and the assignment<br>
<br>
  SupportsDebugInformation = CompileForDebugging;<br>
<br>
Isn&#39;t this redundant code? If yes then the attached patch should be committed. If \
not then I like to know whats going on here....<br> <br>
Regards<span class="HOEnZb"><font color="#888888"><br>
Kai<br>
</font></span><br>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a>         <a \
href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br> <a \
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" \
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br> \
<br></blockquote></div><br><br clear="all"><div><br></div>-- \
<br><br><div>Thanks,</div><div><br></div><div>Justin Holewinski</div><br> </div>



_______________________________________________
LLVM Developers mailing list
LLVMdev@cs.uiuc.edu         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev


[prev in list] [next in list] [prev in thread] [next in thread]