[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-dev
Subject:    Re: [LLVMdev] [patch] MicroBlaze Backend
From:       Anton Korobeynikov <anton () korobeynikov ! info>
Date:       2010-01-30 18:59:02
Message-ID: b087fca01001301059q7e4a1c5aofad92858ce0e39c0 () mail ! gmail ! com
[Download RAW message or body]

Hello, Wesley

> > More comments:
> > > +SDValue MBlazeTargetLowering::
> > > +LowerDYNAMIC_STACKALLOC(SDValue Op, SelectionDAG &DAG) {
> > Do you really need this? Expanding dynamic allocas normally ends with
> > stack register adjustment, you don't need anything special here.
> I was unsure as to whether I needed this or not. I have been taking the approach of \
> removing things conservatively as I continue to improve the backend. I will take a \
> look at removing this for the next patch.
Well, the code to trigger this is quite simple:

define void @t() nounwind {
A:
        br label %entry

entry:
        %m1 = alloca i32, align 4
        %m2 = alloca [7 x i8], align 16
        call void @s( i32* %m1, [7 x i8]* %m2 )
        ret void
}

declare void @s(i32*, [7 x i8]*)

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University
_______________________________________________
LLVM Developers mailing list
LLVMdev@cs.uiuc.edu         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev


[prev in list] [next in list] [prev in thread] [next in thread]