[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    [PATCH] D140811: [DAGCombiner][X86] `visitVECTOR_SHUFFLE()`: splats with a single non-undef element 
From:       Simon Pilgrim via Phabricator via llvm-commits <llvm-commits () lists ! llvm ! org>
Date:       2022-12-31 21:52:45
Message-ID: qj30e0ZCTQCyKdudQZxbeg () geopod-ismtpd-2-0
[Download RAW message or body]

RKSimon added a comment.

Cheers - I'll review the x86 diffs and get back to you



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:23792
+    // might be free. But only if there are at least two non-undef indices.
+    if (OtherSVN->isSplat() &&
+        count(OtherSVN->getMask(), OtherSVN->getSplatIndex()) > 1)
----------------
Instead of the count() - it might be worth adding a bool arg to \
isSplat()/isSplatMask() to only match splats with more than a single matching \
element?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140811/new/

https://reviews.llvm.org/D140811

_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


[prev in list] [next in list] [prev in thread] [next in thread]