[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    [PATCH] D140798: [InstCombine] Fold zero check followed by decrement to usub.sat
From:       Jamie Hill-Daniel via Phabricator via llvm-commits <llvm-commits () lists ! llvm ! org>
Date:       2022-12-31 15:18:54
Message-ID: pQOhfgodSLyneQHLc0VGuQ () geopod-ismtpd-1-0
[Download RAW message or body]

clubby789 marked 4 inline comments as done.
clubby789 added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/saturating-add-sub.ll:533
+  ret i8 %i2
+}
+
----------------
nikic wrote:
> Especially if this is implemented as a separate fold, we'd want some negative test \
> cases here, e.g. incorrect constants (vary zero/one), incorrect operands (not %a \
> both time), incorrect icmp predicate. 
> As you are using `m_Zero()` matchers, which allow undef/poison in vectors, we'd \
> want to test that as well.
Sorry, I'm not quite sure how to test the vector case you mentioned.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140798/new/

https://reviews.llvm.org/D140798

_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


[prev in list] [next in list] [prev in thread] [next in thread]