[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    [PATCH] D112895: [CVP] Canonicalize signed relational comparisons of scalar integers to unsigned com
From:       Nikita Popov via Phabricator via llvm-commits <llvm-commits () lists ! llvm ! org>
Date:       2021-10-31 22:28:28
Message-ID: PQTY_043QD-gvW4sFKVF1w () ismtpd0175p1mdw1 ! sendgrid ! net
[Download RAW message or body]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM. Might want to regenerate the tests again, as the changes to instruction names should be gone now.



================
Comment at: llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp:302
+  if (Cmp->getType()->isVectorTy() ||
+      !Cmp->getOperand(0)->getType()->isIntegerTy())
+    return false;
----------------
Second condition is probably redundant, can't have anything else in a scalar icmp.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112895/new/

https://reviews.llvm.org/D112895

_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

[prev in list] [next in list] [prev in thread] [next in thread]