[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    [PATCH] D110869: [X86] Implement -fzero-call-used-regs option
From:       Bill Wendling via Phabricator via llvm-commits <llvm-commits () lists ! llvm ! org>
Date:       2021-09-30 22:33:06
Message-ID: XZ_5NR4YSiabx8bIjQlYhQ () geopod-ismtpd-6-0
[Download RAW message or body]

void added inline comments.


================
Comment at: clang/include/clang/Basic/AttrDocs.td:6116
+
+- ``skip`` doesn't zero any call-used registers.
+- ``used`` only zeros call-used registers used in the function. By ``used``, we
----------------
void wrote:
> nickdesaulniers wrote:
> > Might be worth a note that `skip` is helpful for disabling previously occurring \
> > instances of the command line flag.  Sometimes toolchains have wrapper scripts \
> > that force on flags, or are built with the implicit default changed, so being \
> > able to explicitly disable a feature can be helpful.
> Doesn't that apply to all (or most) flags though? I don't think they mention that \
> you can override previously set flags...
Oh, I see what you mean now. I'll see what I can do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110869/new/

https://reviews.llvm.org/D110869

_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


[prev in list] [next in list] [prev in thread] [next in thread]