[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    [PATCH] D110081: [llvm-profgen] Filter out invalid debug line
From:       Lei Wang via Phabricator via llvm-commits <llvm-commits () lists ! llvm ! org>
Date:       2021-09-30 22:13:50
Message-ID: JroK65YxRFC2YUXd1XbjaQ () ismtpd0153p1iad2 ! sendgrid ! net
[Download RAW message or body]

wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:543
+      // Filter out invalid negative(int type) lineOffset
+      if (LineOffset & 0x80000000)
+        return SampleContextFrameVector();
----------------
hoy wrote:
> Can we potentially lose contexts when an invalid line offset is one of the frames? \
> Like `A:-1 @ B:2 @ C:3`, without this change, we could still have samples for `B:2 \
> @ C:3`. But I think that's rare. 
> LGTM.
> Can we potentially lose contexts when an invalid line offset is one of the frames? \
> Like A:-1 @ B:2 @ C:3, without this change, we could still have samples for B:2 @ \
> C:3. But I think that's rare.

I haven't seen those cases, it seems it only happened for leaf frame. Even it can be \
leaf call, there is no samples hit the callee. I can add a warning on the non-leaf \
frame invalid line of stack address.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110081/new/

https://reviews.llvm.org/D110081

_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


[prev in list] [next in list] [prev in thread] [next in thread]