[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    [PATCH] D99692: [globalisel][unittests] Rename setUp() to avoid potential mix up with SetUp() from g
From:       Justin Bogner via Phabricator via llvm-commits <llvm-commits () lists ! llvm ! org>
Date:       2021-03-31 23:54:12
Message-ID: jQa5DF7zQuOZJewlf0QtBw () geopod-ismtpd-2-1
[Download RAW message or body]

bogner accepted this revision.
bogner added a comment.
This revision is now accepted and ready to land.

The title/summary seems a bit confusing. The interesting part of this change is \
having the set up function return a target machine so it's impossible to miss - IMO \
renaming it is incidental. This seems reasonable to do, but I think it'd be better \
titled something along the lines of "Return a target machine from the test setup so \
that it's structurally required"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99692/new/

https://reviews.llvm.org/D99692

_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


[prev in list] [next in list] [prev in thread] [next in thread]