[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    [PATCH] D99399: [elfabi] Prepare llvm-elfabi for elfabi/ifs merging.
From:       Puyan Lotfi via Phabricator via llvm-commits <llvm-commits () lists ! llvm ! org>
Date:       2021-03-31 23:13:42
Message-ID: zGKOMRMDTmuORRQXzfuzPA () ismtpd0177p1iad2 ! sendgrid ! net
[Download RAW message or body]

plotfi added inline comments.


================
Comment at: llvm/lib/InterfaceStub/TBEHandler.cpp:198
+  else
+    YamlOut << *dynamic_cast<ELFStub *>(CopyStub.get());
+  return Error::success();
----------------
haowei wrote:
> plotfi wrote:
> > Do we even support dynamic_casts in LLVM anymore? I might be missing something \
> > here, sorry. 
> I tried dyn_cast seems not working.  Not sure if dynamic_casts is allowed or not so \
> I just change it static_cast.
LLVM is compiled with no-rtti and no exceptions afaik. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99399/new/

https://reviews.llvm.org/D99399

_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


[prev in list] [next in list] [prev in thread] [next in thread]