[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    [PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF
From:       Sriraman Tallam via Phabricator via llvm-commits <llvm-commits () lists ! llvm ! org>
Date:       2021-03-31 22:39:47
Message-ID: P0fvrLpmTRuSBmSRDMsc0g () ismtpd0178p1mdw1 ! sendgrid ! net
[Download RAW message or body]

tmsriram added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1712
+          COFF::IMAGE_SCN_MEM_READ | COFF::IMAGE_SCN_LNK_COMDAT,
+      SectionKind::getText(), COMDATSymName,
+      COFF::IMAGE_COMDAT_SELECT_NODUPLICATES, UniqueID);
----------------
MaskRay wrote:
> TaoPan wrote:
> > tmsriram wrote:
> > > COMDATSymName can be folded to be equal to MBB.getSymbol()->getName() here?  \
> > > Plus, you are not preserving the .text.hot prefix that the original function \
> > > might get here.  Is this future work?  If the original function is named \
> > > .text.hot.foo, the basic block will still be named .text.foo.__part.1 which is \
> > > not right. 
> > > Plus, what about exception handling sections like ".eh.*"?
> > Thanks! I'll redesign section name and comdat symbol name.
> > The text section with prefix "hot" and "unlikely" won't be constructed here, I \
> > added COFF text section prefix "hot" and "unlikely" in D92073. In ELF override \
> > function, also not handling text section with prefix "hot" and "unlikely". The \
> > text section with prefix "split" will be constructed here, I plan to add related \
> > code in MFS COFF patch. Also, exception handling section is future work that \
> > support basic block sections Windows COFF exception handling.
> This is complex. PE-COFF has multiple COMDAT seletion kinds. I want to see a \
> holistic plan how every component is going to be implemented.
The basic block should just mimic the COMDAT type of its containing function, is \
there a reason to do anything more with it here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99487/new/

https://reviews.llvm.org/D99487

_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


[prev in list] [next in list] [prev in thread] [next in thread]