[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer
From:       Pavel Labath via Phabricator via llvm-commits <llvm-commits () lists ! llvm ! org>
Date:       2018-09-30 17:22:26
Message-ID: 181acd56fcb55c984a6a6b71351d7236 () localhost ! localdomain
[Download RAW message or body]

labath added inline comments.
Herald added a subscriber: arphaman.


================
Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:179
+  if (!m_die_array.empty()) {
+    lldbassert(!m_first_die || m_first_die == m_die_array.front());
+    m_first_die = m_die_array.front();
----------------
xbolva00 wrote:
> xbolva00 wrote:
> > @jankratochvil is this correct assert? Our downstream lldb based on lldb 7 with \
> > our custom targets hits this assert.  If we remove it, we see no obvious \
> > breakages.
> cc @labath 
I agree with Jan. The two dies should be the same. The fact that they aren't probably \
means there is a bug somewhere. It would be good to know how the two dies differ and \
what is the input dwarf they are generated from.


Repository:
  rL LLVM

https://reviews.llvm.org/D46810



_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


[prev in list] [next in list] [prev in thread] [next in thread]