[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    [PATCH] D41644: Rename --icf-data and add a corresponding flag for functions
From:       George Rimar via Phabricator via llvm-commits <llvm-commits () lists ! llvm ! org>
Date:       2017-12-31 10:46:30
Message-ID: 94a7ebc4986b0ebee49fc5dfbb619d5f () localhost ! localdomain
[Download RAW message or body]

grimar added inline comments.


================
Comment at: ELF/Relocations.cpp:575
+
+  return false;
+}
----------------
Not a big deal but may be just

```
  return (Sym.isFunc() && Config->IgnoreFunctionAddressEquality) ||
         (Sym.isObject() && Config->IgnoreDataAddressEquality);
```


================
Comment at: test/ELF/protected-data-access.s:12
+
+# Check that we have a capy relocation.
+
----------------
capy -> copy


https://reviews.llvm.org/D41644



_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

[prev in list] [next in list] [prev in thread] [next in thread]