[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    [PATCH] D34910: Make LLVM_TARGETS_TO_BUILD=all build all targets
From:       Matthias Braun via Phabricator via llvm-commits <llvm-commits () lists ! llvm ! org>
Date:       2017-06-30 23:44:34
Message-ID: 1c1a343e89881a647f1f0c5bc5f35437 () localhost ! localdomain
[Download RAW message or body]

MatzeB added a comment.

In https://reviews.llvm.org/D34910#797469, @mehdi_amini wrote:

> In https://reviews.llvm.org/D34910#797402, @silvas wrote:
> 
> > IIRC the intention was that in-tree work should not be burdened by experimental \
> > targets, up to and including breaking them. E.g. an in-tree API migration \
> > wouldn't have to update experimental targets. So in that sense \
> > `LLVM_TARGETS_TO_BUILD=all` is working as intended I think.
> 
> 
> Yes this is correct: but what matters on this aspect is the *default* isn't it? A \
> bot does not have to specify LLVM_TARGETS_TO_BUILD, and as long as the default does \
> not include the experimental target that seems fine to me.


Yes the patch as is is perfectly fine and we can push it right away.
However it obviously smells like the next thing happening is a commit to `zorg` \
putting `LLVM_TARGET_TO_BUILD=all` on some buildbots. Before this patch it wasn't \
possible to do that so conveniently as this. So I am raising my complaint early so \
nobody does that hypethical `zorg` commit without discussion on llvm-dev!


Repository:
  rL LLVM

https://reviews.llvm.org/D34910



_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


[prev in list] [next in list] [prev in thread] [next in thread]