[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    [llvm] r277308 - Comment fixes to MemorySSA.h
From:       Daniel Berlin via llvm-commits <llvm-commits () lists ! llvm ! org>
Date:       2016-07-31 21:08:11
Message-ID: 20160731210811.450802A6C053 () llvm ! org
[Download RAW message or body]

Author: dannyb
Date: Sun Jul 31 16:08:10 2016
New Revision: 277308

URL: http://llvm.org/viewvc/llvm-project?rev=277308&view=rev
Log:
Comment fixes to MemorySSA.h

Modified:
    llvm/trunk/include/llvm/Transforms/Utils/MemorySSA.h
    llvm/trunk/unittests/Transforms/Utils/MemorySSA.cpp

Modified: llvm/trunk/include/llvm/Transforms/Utils/MemorySSA.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Transforms/Utils/MemorySSA.h?rev=277308&r1=277307&r2=277308&view=diff
 ==============================================================================
--- llvm/trunk/include/llvm/Transforms/Utils/MemorySSA.h (original)
+++ llvm/trunk/include/llvm/Transforms/Utils/MemorySSA.h Sun Jul 31 16:08:10 2016
@@ -534,7 +534,9 @@ public:
     return It == PerBlockAccesses.end() ? nullptr : It->second.get();
   }
 
-  /// \brief Create an empty MemoryPhi in MemorySSA
+  /// \brief Create an empty MemoryPhi in MemorySSA for a given basic block.
+  /// Only one MemoryPhi for a block exists at a time, so this function will
+  /// assert if you try to create one where it already exists.
   MemoryPhi *createMemoryPhi(BasicBlock *BB);
 
   enum InsertionPlace { Beginning, End };

Modified: llvm/trunk/unittests/Transforms/Utils/MemorySSA.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Transforms/Utils/MemorySSA.cpp?rev=277308&r1=277307&r2=277308&view=diff
 ==============================================================================
--- llvm/trunk/unittests/Transforms/Utils/MemorySSA.cpp (original)
+++ llvm/trunk/unittests/Transforms/Utils/MemorySSA.cpp Sun Jul 31 16:08:10 2016
@@ -67,7 +67,7 @@ public:
 
 TEST_F(MemorySSATest, CreateALoadAndPhi) {
   // We create a diamond where there is a store on one side, and then after
-  // running memory ssa, create a load after the merge point, and use it to test
+  // building MemorySSA, create a load after the merge point, and use it to test
   // updating by creating an access for the load and a memoryphi.
   F = Function::Create(
       FunctionType::get(B.getVoidTy(), {B.getInt8PtrTy()}, false),


_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


[prev in list] [next in list] [prev in thread] [next in thread]