[prev in list] [next in list] [prev in thread] [next in thread] 

List:       llvm-commits
Subject:    Re: [PATCH] D21636: [PM] LoopAccessInfo Refactor #2
From:       Xinliang David Li via llvm-commits <llvm-commits () lists ! llvm ! org>
Date:       2016-06-30 23:18:01
Message-ID: CALRgJCONb2mLTWF8OZrByUXJy-n_tiaTruurnz2jMig91faQsg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Doh! That is indeed unfortunate. Will update the patch.

David

On Thu, Jun 30, 2016 at 4:14 PM, Sean Silva via llvm-commits <
llvm-commits@lists.llvm.org> wrote:

> silvas added a comment.
>
> Quick comment to avoid a buildbot issue.
>
>
> ================
> Comment at: include/llvm/Analysis/LoopAccessAnalysis.h:518
> @@ -517,1 +517,3 @@
>
> +  LoopAccessInfo(LoopAccessInfo &&LAI) = default;
> +  LoopAccessInfo &operator=(LoopAccessInfo &&LAI) = default;
> ----------------
> The issue with MSVC is actually that it can't synthesize this, so `=
> default` doesn't help unfortunately. You have to manually write out the
> entire move ctor like you had it. Just make sure to add a comment " // Hack
> for MSVC 2013 which seems like it can't synthesize this." or similar.
>
>
> http://reviews.llvm.org/D21636
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>

[Attachment #5 (text/html)]

<div dir="ltr">Doh! That is indeed unfortunate. Will update the \
patch.<div><br></div><div>David</div></div><div class="gmail_extra"><br><div \
class="gmail_quote">On Thu, Jun 30, 2016 at 4:14 PM, Sean Silva via llvm-commits \
<span dir="ltr">&lt;<a href="mailto:llvm-commits@lists.llvm.org" \
target="_blank">llvm-commits@lists.llvm.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">silvas added a comment.<br> <br>
Quick comment to avoid a buildbot issue.<br>
<br>
<br>
================<br>
Comment at: include/llvm/Analysis/LoopAccessAnalysis.h:518<br>
@@ -517,1 +517,3 @@<br>
<br>
+   LoopAccessInfo(LoopAccessInfo &amp;&amp;LAI) = default;<br>
+   LoopAccessInfo &amp;operator=(LoopAccessInfo &amp;&amp;LAI) = default;<br>
----------------<br>
The issue with MSVC is actually that it can&#39;t synthesize this, so `= default` \
doesn&#39;t help unfortunately. You have to manually write out the entire move ctor \
like you had it. Just make sure to add a comment &quot; // Hack for MSVC 2013 which \
seems like it can&#39;t synthesize this.&quot; or similar.<br> <div \
class="HOEnZb"><div class="h5"><br> <br>
<a href="http://reviews.llvm.org/D21636" rel="noreferrer" \
target="_blank">http://reviews.llvm.org/D21636</a><br> <br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" \
rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
 </div></div></blockquote></div><br></div>


[Attachment #6 (text/plain)]

_______________________________________________
llvm-commits mailing list
llvm-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


[prev in list] [next in list] [prev in thread] [next in thread]