[prev in list] [next in list] [prev in thread] [next in thread]
List: llvm-commits
Subject: Re: [llvm] r215224 - Delete dead code. NFC.
From: Dimitar Dobrev <dpldobrev () yahoo ! com>
Date: 2014-08-11 18:11:28
Message-ID: 1407780688.80372.YahooMailNeo () web122402 ! mail ! ne1 ! yahoo ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
I completely agree with you. This was exactly my point - however, you said it better. I \
am also ready to contribute to this additional support. In fact, I've already sent a patch for \
the COFF case at ⚙ D4727 Fixed the getting of names and look-up entries of DLL imports.I have \
also fixed needed_library_begin and I am ready to send another patch if this function is \
restored to the code base.
Regards,
Dimitar
⚙ D4727 Fixed the getting of names and look-up entries of DLL imports.
Press ? to show keyboard shortcuts. Author ddobrev Reviewers rafael Lint ★ Lint Skipped Unit \
★ Unit Tests Skipped Apply Patch arc patch D4727 Projects llvm Subscribers Restricted Mailing \
List View on reviews.llvm.org Preview by Yahoo
[Attachment #5 (text/html)]
<html><body><div style="color:#000; background-color:#fff; font-family:HelveticaNeue, Helvetica \
Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:12pt"><div class="" style="color: \
rgb(0, 0, 0); font-size: 16px; font-family: serif; background-color: transparent; font-style: \
normal;"><span style="" class=""><br style=""></span></div><div class="" style="color: rgb(0, \
0, 0); font-size: 16px; font-family: serif; background-color: transparent; font-style: \
normal;"><span style="" class=""> </span><span style="" class="">I completely \
agree with you. This was exactly my point - however, you said it better. I am also ready to \
contribute to this additional support. In fact, I've already sent a patch for the COFF case at \
<a style="" class="" href="http://reviews.llvm.org/D4727">⚙ D4727 Fixed the getting of names \
and look-up entries of DLL imports.</a> I have also fixed needed_library_begin and I am ready \
to send another patch if this function is restored to the code base.</span></div><div class="" \
style="color: rgb(0, 0, 0); font-size: 16px; font-family: serif; background-color: transparent; \
font-style: normal;"><br><span style="" class=""></span></div><div class="" style="color: \
rgb(0, 0, 0); font-size: 16px; font-family: serif; background-color: transparent; font-style: \
normal;"><span class="tab"> Regards,</span><span \
class="tab"><br></span></div><div class="" style="color: rgb(0, 0, 0); font-size: 16px; \
font-family: serif; background-color: transparent; font-style: normal;"><span \
class="tab"> Dimitar</span><span style="" class=""> </span></div><div \
style="width:450px; font-family: 'Georgia', 'Times', 'Times New Roman', 'serif';margin-top:5px; \
margin-bottom: 5px;" id="enhancrCard_2" class="link-enhancr-attachment link-enhancr-element" \
contenteditable="false"><table class="link-enhancr-element" style="width:450px; height:auto; \
position: relative; display: block;" border="0" cellpadding="0" cellspacing="0"><tbody><tr \
class="link-enhancr-element"><td class="link-enhancr-element" colspan="7" style="height: 1px; \
background-color: #e5e5e5; font-size: 1px; border-collapse: collapse;"><div \
class="link-enhancr-element" style="height: 1px; background-color: #e5e5e5; font-size: 1px; \
line-height:0px;"> </div></td></tr><tr class="link-enhancr-element"><td rowspan="5" \
class="link-enhancr-element" style="width: 1px; background-color: #e5e5e5; font-size: 1pt; \
border-collapse: collapse;"><div class="link-enhancr-element" style="width: 1px; \
background-color: #e5e5e5; font-size: 1pt;"> </div></td><td rowspan="5" \
class="link-enhancr-element" style="width: 14px; background-color: #ffffff; font-size: 0pt; \
border-collapse: collapse;"><div class="link-enhancr-element" style="width: 14px; \
background-color: #ffffff; font-size: 14pt;"> </div></td><td colspan="2" \
class="link-enhancr-element" style="height: 6px; background-color: #ffffff; font-size: 0pt; \
border-collapse: collapse;"><div class="link-enhancr-element" style="height: 6px; \
background-color: #ffffff; font-size: 6pt;"> </div></td><td rowspan="5" \
class="link-enhancr-element" style="width: 20px; background-color: #ffffff; font-size: 0pt; \
border-collapse: collapse;"><div class="link-enhancr-element" style="width: 20px; \
background-color: #ffffff; font-size: 20pt;"> </div></td><td class="link-enhancr-element" \
rowspan="5" style="width: 1px; background-color: #e5e5e5; font-size: 1pt; border-collapse: \
collapse;" width="1"><div class="link-enhancr-element" style="width: 1px; background-color: \
#e5e5e5; font-size: 1pt;"> </div></td></tr><tr><td class="link-enhancr-element" \
colspan="2" style="width: 100%; vertical-align: middle; font-family: 'Georgia', 'Times', 'Times \
New Roman', 'serif';"><div class="link-enhancr-text-part link-enhancr-element" \
style="line-height:16.5px; background-color: #ffffff; width: 414px;"><div \
class="link-enhancr-element" style="word-wrap: break-word; word-break: break-all;"><span \
class="link-enhancr-element icon icon-shrink link-enhancr-toggle"></span><span \
class="link-enhancr-element icon icon-close link-enhancr-delete"></span><a \
href="http://reviews.llvm.org/D4727" class="link-enhancr-card-urlWrapper link-enhancr-element" \
style="text-decoration: none !important; color: #000000 !important; line-height: 100%; \
font-size: 18px; display: block;"><span class="link-enhancr-element link-enhancr-card-title" \
style="margin: 0; font-weight: normal;margin-bottom: 3px; font-size: 18px; line-height: 21px; \
max-height: 43px; color: #000000; overflow: hidden !important; display: inline-block;">⚙ \
D4727 Fixed the getting of names and look-up entries of DLL imports.</span></a><div \
style="font-size: 13px; line-height: 20px; color: #999999; max-height: 81px; font-family: \
'Georgia', 'Times', 'Times New Roman', 'serif';overflow: hidden;" \
class="link-enhancr-card-description link-enhancr-element">Press ? to show keyboard shortcuts. \
Author ddobrev Reviewers rafael Lint ★ Lint Skipped Unit ★ Unit Tests Skipped Apply Patch \
arc patch D4727 Projects llvm Subscribers Restricted Mailing List \
</div></div></div></td></tr><tr><td colspan="2" class="link-enhancr-element" style="height: \
6px; background-color: #ffffff; font-size: 0pt; border-collapse: collapse;"><div \
class="link-enhancr-element" style="height: 6px; background-color: #ffffff; font-size: \
6pt;"></div></td></tr><tr><td class="link-enhancr-element" style="vertical-align: middle; \
font-family: 'Arial', 'Helvetica Neue', 'Helvetica', 'sans-serif';"><div \
class="link-enhancr-element" style="font-size: 0pt;"><a href="http://reviews.llvm.org/D4727" \
class="link-enhancr-card-url link-enhancr-element" style="color: black; text-decoration: none \
!important;cursor:pointer !important;" target="_blank"><span class="link-enhancr-element \
link-enhancr-view-on" style="display: inline-block; line-height: 11px; max-width: 314px; \
min-width: 254px; overflow: hidden; max-height: 13px; word-break: break-all;"><span \
class="link-enhancr-element link-enhancr-mobile-no-resize" style="vertical-align:middle; \
font-size: 9px; line-height: 11px; color: #999999; -moz-text-size-adjust: none; \
-ms-text-size-adjust: none; -webkit-text-size-adjust:none; text-size-adjust:none;">View on \
<span style="font-weight: bold" \
class="link-enhancr-view-on-domain">reviews.llvm.org</span></span></span></a></div></td><td \
class="link-enhancr-element" style="vertical-align: middle; width: 100px; font-family: 'Arial', \
'Helvetica Neue', 'Helvetica', 'sans-serif';"><div class="link-enhancr-element \
link-enhancr-preview-wrapper" style="max-width: 100px; min-width: 80px; overflow: hidden; \
text-align: right; line-height: 11px; max-height: 13px; font-size: 0pt;"><span \
class="link-enhancr-element link-enhancr-preview-by link-enhancr-mobile-no-resize" \
style="vertical-align:middle; font-size: 9px; line-height: 11px; color: #999999; \
-moz-text-size-adjust: none; -ms-text-size-adjust: none; -webkit-text-size-adjust:none; \
text-size-adjust:none;">Preview by Yahoo</span></div></td></tr><tr><td colspan="2" \
class="link-enhancr-element" style="height: 9px; background-color: #ffffff; font-size: 0pt; \
border-collapse: collapse;"><div class="link-enhancr-element" style="height: 9px; \
background-color: #ffffff; font-size: 9pt;"></div></td></tr><tr \
class="link-enhancr-element"><td class="link-enhancr-element" colspan="7" style="height: 1px; \
background-color: #e5e5e5; font-size: 1px; border-collapse: collapse;"><div \
class="link-enhancr-element" style="height: 1px; background-color: #e5e5e5; font-size: 1px; \
line-height:0px"> </div></td></tr></tbody></table></div></div></body></html>
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic